Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

coreos-base/gmerge: Stop installing gmerge script #828

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

krnowak
Copy link
Contributor

@krnowak krnowak commented Feb 4, 2021

It is not used anywhere during the build process, thus drop
it. Dropping it makes it easier to port this ebuild to python3, since
there will be only one script to port to python3. The
emerge-gitclone script will need porting anyway, because it imports
portage code, which will become python3 after the update.

Most likely the package should be then renamed to
coreos-base/emerge-gitclone, but this can be done later.

Test build passed just fine without the tool. It's being pulled into dev container through coreos-base/dev-util package.

Test build: http://localhost:9091/job/os/job/toolchains/1294/

It is not used anywhere during the build process, thus drop
it. Dropping it makes it easier to port this ebuild to python3, since
there will be only one script to port to python3. The
`emerge-gitclone` script will need porting anyway, because it imports
portage code, which will become python3 after the update.

Most likely the package should be then renamed to
`coreos-base/emerge-gitclone`, but this can be done later.
Copy link
Contributor

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I cannot figure out why gmerge was installed.
It was just like that since the beginning.

coreos-base/cros-devutils still calls gmerge, but only if ! cros_host.
So it looks ok to remove gmerge.

@krnowak
Copy link
Contributor Author

krnowak commented Feb 5, 2021

Yeah, and funnily enough, gmerge is gone at upstream - https://chromium.googlesource.com/chromiumos/platform/dev-util/+/refs/heads/main

@krnowak krnowak merged commit f5e39ac into main Feb 5, 2021
@krnowak krnowak deleted the krnowak/drop-gmerge-script branch February 5, 2021 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants