Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

delete dhcpcd, containerd-stress #858

Merged
merged 2 commits into from Feb 22, 2021
Merged

Conversation

dongsupark
Copy link
Contributor

Now that dhcpcd was removed from portage-stable, we can simply delete dependency on dhcpcd.

Each Flatcar production image includes a binary containerd-stress, as a part of torcx tarballs.
However it does not seem to be used anywhere.
It looks like a stress testing tool for containerd, so I don't see a good reason to keep it.
The binary was there since the beginning, via commit fdd926949a10, but there is no comment or messages why it was needed.
We can simply remove containerd-stress.

This PR should be merged together with flatcar-archive/portage-stable#149.

Testing done

CI passed: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/2075/cldsv/ (part of a combined testing branch)

Dongsu Park added 2 commits February 22, 2021 15:02
Now that dhcpcd was removed from portage-stable, we can simply delete
dependency on dhcpcd.
Each Flatcar production image includes a binary `containerd-stress`,
as a part of torcx tarballs.

However it does not seem to be used anywhere.
It looks like a stress testing tool for containerd, so I don't see a
good reason to keep it.
The binary was there since the beginning, via commit
[fdd9269](fdd9269),
but there is no comment or messages why it was needed.
We can simply remove `containerd-stress`.
Copy link
Contributor

@margamanterola margamanterola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsupark dongsupark merged commit d9daae1 into main Feb 22, 2021
@dongsupark dongsupark deleted the dongsu/delete-ctstress-dhcpcd branch February 22, 2021 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
alpha enhancement New feature or request
Projects
None yet
2 participants