Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirt: wrong key name for fw_cfg #244

Closed
tormath1 opened this issue Aug 12, 2019 · 5 comments
Closed

libvirt: wrong key name for fw_cfg #244

tormath1 opened this issue Aug 12, 2019 · 5 comments

Comments

@tormath1
Copy link
Contributor

@tormath1 tormath1 commented Aug 12, 2019

Bug

Hi ! ignition file is not mounted with qemu if we use opt/com.flatcar/config as key name for the firewall configuration. (as suggested in the doc: https://docs.flatcar-linux.org/os/booting-with-libvirt/#running-flatcar-linux-on-libvirt). We need to use opt/com.coreos/config. We need to fix the documentation or the const value. (I don't know what is the best)

Operating System Version

$ uname -r 
5.2.8-arch1-1-ARCH
$ virsh version
Compiled against library: libvirt 5.5.0
Using library: libvirt 5.5.0
Using API: QEMU 5.5.0
Running hypervisor: QEMU 4.0.0

Ignition Version

?

Environment

I am using QEMU hypervisor.

Expected Behavior

System should boot and read ignition provided file.

Actual Behavior

Ignition file is ignored

Reproduction Steps

  1. Follow the doc

Other Information

https://github.com/flatcar-linux/ignition/blob/8e2ef5adcc07692ab0c76c9d45e5fad82cedb7a4/internal/providers/qemu/qemu.go#L31-L33

@dongsupark
Copy link
Member

@dongsupark dongsupark commented Aug 13, 2019

Thanks for the bug report!

That definitely looks like a bug.
As @iaguis suggested, we should probably change the string to opt/org.flatcar-linux/config.
Will soon prepare the fix.

Loading

@tormath1
Copy link
Contributor Author

@tormath1 tormath1 commented Aug 13, 2019

I can open a PR if you want :)

Loading

@dongsupark
Copy link
Member

@dongsupark dongsupark commented Aug 13, 2019

Thanks.

But I suppose, fixing only the ignition part is not enough.
We should fix the same thing also in mantle, scripts, etc.
Also there seems to be a corner case in coreos-overlay, about go mod and mantle, etc.
I'll try to create those PRs as soon as possible, and get feedback from other folks.

Loading

dongsupark referenced this issue in flatcar-linux/mantle Aug 13, 2019
To fix a wrong key name when running a qemu VM with ignition, we need to
replace `opt/com.coreos` with `opt/org.flatcar-linux`.

See also https://github.com/flatcar-linux/ignition/issues/2
dongsupark referenced this issue in flatcar-linux/scripts Aug 13, 2019
To fix a wrong key name when running a qemu VM with ignition, we need to
replace `opt/com.coreos` with `opt/org.flatcar-linux`.

See also https://github.com/flatcar-linux/ignition/issues/2
dongsupark referenced this issue in flatcar-linux/coreos-overlay Aug 13, 2019
To fix a wrong key name when running a qemu VM with ignition, we need to
replace `opt/com.coreos` with `opt/org.flatcar-linux`.

See also https://github.com/flatcar-linux/ignition/issues/2
@dongsupark
Copy link
Member

@dongsupark dongsupark commented Aug 13, 2019

Loading

dongsupark referenced this issue in flatcar-linux/coreos-overlay Aug 14, 2019
To fix a wrong key name when running a qemu VM with ignition, we need to
replace `opt/com.coreos` with `opt/org.flatcar-linux`.

See also https://github.com/flatcar-linux/ignition/issues/2
@dongsupark
Copy link
Member

@dongsupark dongsupark commented Aug 14, 2019

Oh, it was automatically closed. I didn't mean it. :-)
Anyway, we will release new Flatcar images in the next days. With the releases, this issue should be fixed.
If not, feel free to reopen this issue.
Thanks!

Loading

@vbatts vbatts transferred this issue from flatcar-linux/ignition Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants