util/cmdline: support OEM IDs for both flatcar and coreos #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make afterburn work for both OEM ID strings, `flatcar.oem.id` and `coreos.oem.id`, we need to update the cmdline parser to deal with both strings. We should keep the Flatcar string name as `CMDLINE_PLATFORM_FLAG`, since the flag name should also work for the !cl-legacy case. Also add tests for `coreos.oem.id`.
The first name in the list takes precedence, so any other present names are ignored.
|
Added a commit to make it make dealing with the flags more flexible if we want to consider supporting |
|
Looks good, Thanks! |
pothos
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
To make afterburn work for both OEM ID strings,
flatcar.oem.idandcoreos.oem.id, we need to update the cmdline parser to deal with both strings.We should keep the Flatcar string name as
CMDLINE_PLATFORM_FLAG, since the flag name should also work for the !cl-legacy case.Also add tests for
coreos.oem.id.Partly addresses flatcar-linux/Flatcar#16.