Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/cmdline: support OEM IDs for both flatcar and coreos #7

Merged
merged 2 commits into from Feb 13, 2020

Conversation

@dongsupark
Copy link
Member

dongsupark commented Feb 12, 2020

To make afterburn work for both OEM ID strings, flatcar.oem.id and coreos.oem.id, we need to update the cmdline parser to deal with both strings.

We should keep the Flatcar string name as CMDLINE_PLATFORM_FLAG, since the flag name should also work for the !cl-legacy case.

Also add tests for coreos.oem.id.

Partly addresses flatcar-linux/Flatcar#16.

To make afterburn work for both OEM ID strings, `flatcar.oem.id` and
`coreos.oem.id`, we need to update the cmdline parser to deal with
both strings.

We should keep the Flatcar string name as `CMDLINE_PLATFORM_FLAG`,
since the flag name should also work for the !cl-legacy case.

Also add tests for `coreos.oem.id`.
@dongsupark dongsupark added the bug label Feb 12, 2020
@dongsupark dongsupark requested a review from pothos Feb 12, 2020
The first name in the list takes precedence, so any other present
names are ignored.
@pothos pothos force-pushed the dongsu/coreos-oem-id branch from 9d67f31 to 212b2f4 Feb 12, 2020
@pothos

This comment has been minimized.

Copy link
Member

pothos commented Feb 12, 2020

Added a commit to make it make dealing with the flags more flexible if we want to consider supporting ignition.platform.id as well.

@dongsupark

This comment has been minimized.

Copy link
Member Author

dongsupark commented Feb 12, 2020

Looks good, Thanks!

@pothos
pothos approved these changes Feb 12, 2020
@dongsupark dongsupark merged commit c9d380d into flatcar-master Feb 13, 2020
@dongsupark dongsupark deleted the dongsu/coreos-oem-id branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.