Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "app-admin/kubelet-wrapper: replace rkt with docker" #148

Merged
merged 1 commit into from Dec 18, 2019

Conversation

@dongsupark
Copy link
Member

dongsupark commented Dec 16, 2019

It is not simple for kubelet-wrapper to use docker, because upper layers like Lokomotive or Typhoon still rely on rkt-specific flags and env variables.
So let's revert it back to rkt, so we can make kubelet-wrapper work again with the existing code.

Note, in the long run, we should figure out how we can make the wrapper work with both docker and rkt, at least for a transition period.

This reverts commit 8a03df3.

It is not simple for kubelet-wrapper to use docker, because
upper layers like Lokomotive or Typhoon still rely on rkt-specific flags
and env variables. So let's revert it back to rkt, so we can make
kubelet-wrapper work again with the existing code.

Note, in the long run, we should figure out how we can make the wrapper
work with both docker and rkt, at least for a transition period.

This reverts commit 8a03df3.
@dongsupark dongsupark merged commit 1fafb05 into flatcar-master-edge Dec 18, 2019
@dongsupark dongsupark deleted the dongsu/kubelet-wrapper-rkt-edge branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.