Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-kernel: fix kernel build path issues to build coreos-firmware #36

Merged
merged 2 commits into from May 27, 2019

Conversation

Projects
None yet
1 participant
@dongsupark
Copy link
Contributor

commented May 27, 2019

In order to build coreos-firmware correctly, we need to set $KERNEL_DIR and $KBUILD_OUTPUT before doing inherit linux-info. Otherwise $KV_FULL ends up being an invalid path, and as a result, coreos-firmware becomes an empty package.

Also we should make coreos-firmware depend on coreos-sources and coreos-modules, to be able to get a correct list of kernel modules.

We should exclude files that does include a space character ' ' from the firmwares list, to avoid kola tests errors like the following.

    --- FAIL: cl.filesystem/blacklist (0.20s)
             files.go:210: Blacklisted files or directories found:
    /usr/lib64/firmware/brcm/brcmfmac43430a0-sdio.ONDA-V80 PLUS.txt
sys-kernel: fix kernel build path issues to build coreos-firmware
In order to build `coreos-firmware` correctly, we need to set
`$KERNEL_DIR` and `$KBUILD_OUTPUT` before doing `inherit linux-info`.
Otherwise `$KV_FULL` ends up being an invalid path, and as a result,
`coreos-firmware` becomes an empty package.

Also we should make `coreos-firmware` depend on coreos-source and
coreos-modules, to be able to get a correct list of kernel modules.

@dongsupark dongsupark added the bug label May 27, 2019

@dongsupark

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

Added another commit to fix kola tests failing because of unnecessary text files under the firmware directory.

sys-kernel: remove files with blanks to avoid kola test failures
We should exclude files that does include a space character ' '
from the firmwares list, to avoid kola tests errors like the following.

```
    --- FAIL: cl.filesystem/blacklist (0.20s)
             files.go:210: Blacklisted files or directories found:
    /usr/lib64/firmware/brcm/brcmfmac43430a0-sdio.ONDA-V80 PLUS.txt
```

@dongsupark dongsupark force-pushed the dongsu/fix-firmware-kbuilds branch from 703a660 to f5d0a7b May 27, 2019

@dongsupark dongsupark merged commit b6986ab into flatcar-master-edge May 27, 2019

@dongsupark dongsupark deleted the dongsu/fix-firmware-kbuilds branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.