Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-emulation/containerd: make containerd listen on localhost #41

Merged
merged 1 commit into from Jun 28, 2019

Conversation

Projects
None yet
2 participants
@dongsupark
Copy link
Contributor

commented Jun 26, 2019

In the past there had been an issue of containerd listening on a public address with TCP port 10010.
The issue was fixed in all channels, by disabling the gRPC plugin of containerd.
However, Flatcar edge enabled the gRPC plugin again, to support cgroup v2 for containerd.
As a result, the original issue of containerd happened again on Flatcar edge.

To fix that, we should make containerd listen on localhost 127.0.0.1, and a TCP port 10010. See also containerd/cri docs.
Also bump containerd to 1.1.2-r3.

@dongsupark dongsupark added the bug label Jun 26, 2019

@invidian
Copy link
Member

left a comment

Seems reasonable 👍

@dongsupark

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

Wait. I've just realized, it's not a good idea to use the dynamic allocated port. If the port number becomes different, the kola test to check for network listeners cannot work. The current kola test requires a static port number.
I will change stream_server_port back to 10010.

app-emulation/containerd: make containerd listen on localhost
In the past there had been an issue of containerd listening on a public
address with TCP port 10010. The issue was fixed in all channels, by
disabling the gRPC plugin of containerd. [1]  However, Flatcar edge
enabled the gRPC plugin again, to support cgroup v2 for containerd. [2]
As a result, the original issue of containerd happened again on Flatcar
edge.

To fix that, we should make containerd listen on localhost 127.0.0.1,
and a TCP port 10010. See also containerd/cri docs. [3]
Also bump containerd to 1.1.2-r3.

[1] coreos/bugs#2524
[2] 8184af2
[3] https://github.com/containerd/cri/blob/53c2230ec09d3672dbfb39756954b1a4afdb1ab8/docs/config.md

@dongsupark dongsupark force-pushed the dongsu/containerd-listen-port branch from 35d4453 to 27258f4 Jun 27, 2019

@dongsupark dongsupark merged commit 566f8a2 into flatcar-master-edge Jun 28, 2019

@dongsupark dongsupark deleted the dongsu/containerd-listen-port branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.