Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/providers/qemu: check for both coreos and flatcar fw_cfg #8

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@dongsupark
Copy link
Member

dongsupark commented Feb 12, 2020

For backwards compatilibity, we need to check for fw_cfg for both coreos and flatcar.

@dongsupark dongsupark added the bug label Feb 12, 2020
@dongsupark dongsupark requested a review from pothos Feb 12, 2020
internal/providers/qemu/qemu.go Outdated Show resolved Hide resolved
internal/providers/qemu/qemu.go Outdated Show resolved Hide resolved
@dongsupark dongsupark force-pushed the dongsu/coreos-fw-cfg branch from ef4b8f3 to 2b0583c Feb 12, 2020
@dongsupark

This comment has been minimized.

Copy link
Member Author

dongsupark commented Feb 12, 2020

Updated PR

internal/providers/qemu/qemu.go Show resolved Hide resolved
For backwards compatilibity, we need to check for fw_cfg for both
coreos and flatcar.
@dongsupark dongsupark force-pushed the dongsu/coreos-fw-cfg branch from 2b0583c to f0a4857 Feb 12, 2020
@pothos
pothos approved these changes Feb 12, 2020
@dongsupark dongsupark merged commit 43ca793 into flatcar-master Feb 13, 2020
@dongsupark dongsupark deleted the dongsu/coreos-fw-cfg branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.