Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: check both OEM IDs for flatcar and coreos #16

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@dongsupark
Copy link
Member

dongsupark commented Feb 12, 2020

For backwards compatibilities, we need to check both OEM IDs in the kernel command line, flatcar.oem.id and coreos.oem.id.

Partly addresses flatcar-linux/Flatcar#16.

@dongsupark dongsupark requested a review from pothos Feb 12, 2020
@dongsupark dongsupark added the bug label Feb 12, 2020
For backwards compatibilities, we need to check both OEM IDs in the
kernel command line, `flatcar.oem.id` and `coreos.oem.id`.
@dongsupark dongsupark force-pushed the dongsu/coreos-oem-id branch from 69b1277 to 0f78c00 Feb 12, 2020
@dongsupark

This comment has been minimized.

Copy link
Member Author

dongsupark commented Feb 12, 2020

Updated it so it can simply have 2 different network files for both flatcar and coreos.

@pothos
pothos approved these changes Feb 12, 2020
@dongsupark dongsupark merged commit daa7ce3 into flatcar-master Feb 13, 2020
@dongsupark dongsupark deleted the dongsu/coreos-oem-id branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.