Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/tar: ignore EOPNOTSUPP from return value of Setxattr for Stable/Beta/Alpha #2

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@dongsupark
Copy link
Member

dongsupark commented Oct 31, 2019

In some cases, docker service does not start, because torcx is not able to unpack tarball like the following error:

failed to unpack: unpacking \"/usr/share/torcx/store/docker:com.coreos.cl.torcx.tgz\": error extracting tar: operation not supported" image=docker reference=com.coreos.cl

This means Setxattr() returns EOPNOTSUPP, especially when SELinux is disabled on the host.
To work around the issue, let's ignore EOPNOTSUPP.

@dongsupark dongsupark added the bug label Oct 31, 2019
In some cases, docker service does not start, because torcx is
not able to unpack tarball like the following error:

```
failed to unpack: unpacking \"/usr/share/torcx/store/docker:com.coreos.cl.torcx.tgz\":
error extracting tar: operation not supported" image=docker reference=com.coreos.cl
```

This means `Setxattr()` returns EOPNOTSUPP, especially when SELinux
is disabled on the host. To work around the issue, let's ignore
EOPNOTSUPP.
@iaguis
iaguis approved these changes Oct 31, 2019
Copy link
Member

iaguis left a comment

LGTM.

I've built this, tested on a machine with SELINUX=disabled and it worked for me.

@dongsupark dongsupark force-pushed the dongsu/fix-setxattr-eopnotsupp branch from 758eed6 to fe37695 Oct 31, 2019
@dongsupark dongsupark changed the title pkg/tar: ignore EOPNOTSUPP from return value of Setxattr pkg/tar: ignore EOPNOTSUPP from return value of Setxattr for Stable/Beta/Alpha Oct 31, 2019
@dongsupark dongsupark merged commit 6333bc8 into flatcar-master Dec 4, 2019
@dongsupark dongsupark deleted the dongsu/fix-setxattr-eopnotsupp branch Dec 4, 2019
dongsupark added a commit to flatcar-linux/coreos-overlay that referenced this pull request Dec 4, 2019
To fix the recent Setxattr issue in torcx, bump torcx to the
latest commit.

See also flatcar-linux/torcx#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.