Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iscsiadm buffer overflow with open-iscsi v2.1.2 #318

Closed
tilleyc opened this issue Jan 14, 2021 · 5 comments
Closed

iscsiadm buffer overflow with open-iscsi v2.1.2 #318

tilleyc opened this issue Jan 14, 2021 · 5 comments

Comments

@tilleyc
Copy link

tilleyc commented Jan 14, 2021

Description

open-iscsi version 2.1.2 (version included in Flatcar from 2605.9.0) has a bug wherein discovery of too many targets results in buffer overflow in iscsiadm, resulting in the program exiting with errors. This is documented in the Changelog for 2.1.3 and this commit.

Impact

Unable to upgrade past 2605.8.0 as we have approximately 250 targets discovered which triggers the bug and then doesn't mount.

Environment and steps to reproduce

  1. Set-up: Flatcar 2605.9.0 on bare metal
  2. Task: Mount PVC.
  3. Action(s):
    a. Create pod utilizing PVC on a mount.
    b. Container stuck in Creating due to mount failure from program exit.
  4. Error: iscsi: failed to sendtargets to portal 1.2.3.4:3260 output: *** buffer overflow detected ***: terminated , err signal: aborted (core dumped) (IP obfuscated)

Expected behavior
Expect successful mounting of target.

Additional information
This is really more of a request to update to at least open-iscsi version 2.1.3, but I've filed it as a bug since it technically is one (albeit in a dependency). The issue has already been found and documented as seen in the links provided in the description.

This locks us into utilizing 2605.8.0 for the time being.

@t-lo
Copy link
Member

t-lo commented Jan 15, 2021

Thank you for reporting this issue, and please pardon the inconvenience caused. We'll have a look at updating open-iscsi.

@ffilippopoulos
Copy link

@tilleyc for what is worth we had a similar problem when discovering luns from our netapp and managed to work around that via setting scans to manual (node.session.scan = manual) and doing targeted discoveries (which is actually the proposed configuration from trident/netapp for our case). No idea if that can be useful for you though, just mentioning.. :))

@tilleyc
Copy link
Author

tilleyc commented Jan 19, 2021

@tilleyc for what is worth we had a similar problem when discovering luns from our netapp and managed to work around that via setting scans to manual (node.session.scan = manual) and doing targeted discoveries (which is actually the proposed configuration from trident/netapp for our case). No idea if that can be useful for you though, just mentioning.. :))

Interesting, thank you for this. I'll look into it!

@margamanterola
Copy link
Contributor

This was addressed in flatcar-archive/coreos-overlay#791, that updated the iscsi version to 2.1.3.

This will be included in the upcoming set of releases for stable, beta and alpha.

@margamanterola
Copy link
Contributor

The new flatcar releases with these fixes are in the process of getting published. Closing now. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants