Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignition-generator: make the hostname units optional #23

Merged

Conversation

margamanterola
Copy link
Contributor

@margamanterola margamanterola commented Apr 7, 2021

Having the hostname units as required by the initrd.target meant that if
the unit failed (for example because the network was or the metadata
service were down), the machine wouldn't start. By making it a "wants"
rather than a "requires" we allow this unit to fail without disrupting
the whole boot.

Testing done

I ran CI with this change and it succeeded.

Having the hostname units as required by the initrd.target meant that if
the unit failed (for example because the network was or the metadata
service were down), the machine wouldn't start. By making it a "wants"
rather than a "requires" we allow this unit to fail without disrupting
the whole boot.
@margamanterola margamanterola requested a review from a team April 7, 2021 13:23
@margamanterola
Copy link
Contributor Author

CI passed, merging.

@margamanterola margamanterola merged commit c218828 into flatcar-master Apr 8, 2021
@margamanterola margamanterola deleted the marga-kinvolk/make-hostname-optional branch April 8, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants