Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-bootengine: add missing kernel modules back #40

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

pothos
Copy link
Member

@pothos pothos commented Mar 14, 2022

Compared to Flatcar major version 3033 these modules went missing from
the initramfs:
glue_helper.ko.xz md4.ko.xz aoe.ko.xz brd.ko.xz drbd.ko.xz nbd.ko.xz
rbd.ko.xz xen-blkfront.ko.xz zram.ko.xz pps_core.ko.xz ptp.ko.xz
nfs_ssc.ko.xz libarc4.ko.xz lru_cache.ko.xz zsmalloc.ko.xz
The "loop" module already was added because PXE boots broke. The
xen-blkfront module however also broke booting on m4 AWS EC2 instances.
Add those modules from the above list back to the initramfs which are
present on the 5.15 kernel.

How to use

Build and test booting on m4 instances, but it also requires the kernel commit revert for networking

Testing done

Tested that the initramfs has the modules now (unpack Stable 3033.2.3 and this build's vmlinuz with extract-initramfs-from-vmlinuz.sh and look that things like zram.ko.xz don't appear on the left sdiff side but not on the right. Also check dracut logs from coreos-kernel.

sdiff -s  <(ls -R vmlinuz-stable-unpacked/|grep ko.xz|sort) <(ls -R fixed-vmlinuz-unpacked/|grep ko.xz|sort)
							      >	acpi_mdio.ko.xz
aoe.ko.xz						      <
							      >	asn1_encoder.ko.xz
							      >	ax88796b.ko.xz
							      >	cifs_arc4.ko.xz
							      >	cifs_md4.ko.xz
							      >	des_generic.ko.xz
							      >	fixed_phy.ko.xz
							      >	fwnode_mdio.ko.xz
glue_helper.ko.xz					      <
							      >	mana.ko.xz
md4.ko.xz						      <
mlxsw_switchib.ko.xz					      <
mlxsw_switchx2.ko.xz					      <
							      >	netfs.ko.xz
nfs_ssc.ko.xz						      <
pps_core.ko.xz						      <
ptp.ko.xz						      <
							      >	scsi_common.ko.xz
							      >	selftests.ko.xz

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
    ↑ in coreos-overlay

Compared to Flatcar major version 3033 these modules went missing from
the initramfs:
glue_helper.ko.xz md4.ko.xz aoe.ko.xz brd.ko.xz drbd.ko.xz nbd.ko.xz
rbd.ko.xz xen-blkfront.ko.xz zram.ko.xz pps_core.ko.xz ptp.ko.xz
nfs_ssc.ko.xz libarc4.ko.xz lru_cache.ko.xz zsmalloc.ko.xz
The "loop" module already was added because PXE boots broke. The
xen-blkfront module however also broke booting on m4 AWS EC2 instances.
Add those modules from the above list back to the initramfs which are
present on the 5.15 kernel.
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Mar 14, 2022
This pulls in
flatcar/bootengine#40
to add the kernel modules back that disappeared compared to Stable
3033.x.y with the 5.10 kernel.
@pothos pothos marked this pull request as ready for review March 15, 2022 09:55
@pothos pothos requested a review from a team March 15, 2022 09:55
Copy link
Member

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to make more changes to this list, then next time let's create a new dracut module to collect these.

pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Mar 15, 2022
This pulls in
flatcar/bootengine#40
to add the kernel modules back that disappeared compared to Stable
3033.x.y with the 5.10 kernel.
@pothos pothos merged commit b5c1672 into flatcar-master Mar 15, 2022
@pothos pothos deleted the kai/add-missing-modules branch March 15, 2022 10:38
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Mar 15, 2022
This pulls in
flatcar/bootengine#40
to add the kernel modules back that disappeared compared to Stable
3033.x.y with the 5.10 kernel.
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Mar 15, 2022
This pulls in
flatcar/bootengine#40
to add the kernel modules back that disappeared compared to Stable
3033.x.y with the 5.10 kernel.
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Mar 15, 2022
This pulls in
flatcar/bootengine#40
to add the kernel modules back that disappeared compared to Stable
3033.x.y with the 5.10 kernel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants