ignition-kargs-helper: Ensure that grub.cfg exists before reading #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 13, 2022
This pulls in flatcar/bootengine#47 which creates the grub.cfg file if it does not exist when the Ignition kargs directive is used, preventing an error when it tried to read the current settings from it.
1 task
The kola kargs test fails for the generic image when it's not mangled (which is the kola term for setting the console option by creating the grub.cfg file) because the kargs helper didn't handle the case where the file doesn't exist which is normal for the generic image. Create the grub.cfg file if it doesn't exist before trying to read from it.
pothos
force-pushed
the
kai/kargs-nonexisting-grubcfg
branch
from
411ae57 to
914f9d3
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 13, 2022
This pulls in flatcar/bootengine#47 which creates the grub.cfg file if it does not exist when the Ignition kargs directive is used, preventing an error when it tried to read the current settings from it.
jepio
approved these changes
Jul 14, 2022
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 14, 2022
This pulls in flatcar/bootengine#47 which creates the grub.cfg file if it does not exist when the Ignition kargs directive is used, preventing an error when it tried to read the current settings from it.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 14, 2022
This pulls in flatcar/bootengine#47 which creates the grub.cfg file if it does not exist when the Ignition kargs directive is used, preventing an error when it tried to read the current settings from it.
pothos
added a commit
that referenced
this pull request
Jul 14, 2022
ignition-kargs-helper: Ensure that grub.cfg exists before reading
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 14, 2022
This pulls in flatcar/bootengine#47 which creates the grub.cfg file if it does not exist when the Ignition kargs directive is used, preventing an error when it tried to read the current settings from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kola kargs test fails for the generic image when it's not mangled
(which is the kola term for setting the console option by creating the
grub.cfg file) because the kargs helper didn't handle the case where
the file doesn't exist which is normal for the generic image.
Create the grub.cfg file if it doesn't exist before trying to read from
it.
How to use
We can backport it on the bootengine backport branches
Testing done
build
--qemu-skip-mangleas kola flagchangelog/directory (user-facing change, bug fix, security fix, update)↑ in coreos-overlay