This repository has been archived by the owner on May 30, 2023. It is now read-only.
app-emulation/containerd: Switch to default socket location #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream socket is under /run/containerd/containerd.sock which many tools like crictl will use by default and diverging causes users to always have to configure a non-default location. Switch to the upstream default while still keeping a symlink so that users are not forced to update their configurations they had to do for the non-default location. This also keeps Docker using the old socket location as an assertion that the symlink works. The state directory is also switch to the default location.
2 tasks
The service file was missing some options from https://github.com/containerd/containerd/blob/master/containerd.service
pothos
added a commit
that referenced
this pull request
Jan 11, 2021
app-emulation/containerd: Switch to default socket location
pothos
added a commit
that referenced
this pull request
Jan 25, 2021
app-emulation/containerd: Switch to default socket location
pothos
added a commit
that referenced
this pull request
Jan 25, 2021
app-emulation/containerd: Switch to default socket location
|
Picked for flatcar-2605 and flatcar-2705 |
pothos
added a commit
that referenced
this pull request
Feb 1, 2021
app-emulation/containerd: Switch to default socket location
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The upstream socket is under /run/containerd/containerd.sock which many
tools like crictl will use by default and diverging causes users to
always have to configure a non-default location.
Switch to the upstream default while still keeping a symlink so that
users are not forced to update their configurations they had to do for
the non-default location. This also keeps Docker using the old socket
location as an assertion that the symlink works. The state directory
is also switch to the default location.
How to use
Build an image and run the tests
Testing done
Manually created a drop-in config with the new contents.