extend-filesystems: More robustness against kernel partition re-reads #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directly using the device after the resize is prone to races. At least for the size check it's easy to retry until we succeed getting the new size. The filesystem resize call may still fail but the service is limited in this way already because at startup it only checks if the partition size is maximal but not the filesystem size. For future debugging the output is made more verbose. flatcar/Flatcar#235
pothos
force-pushed
the
kai/extend-filesystem-race
branch
from
85d7b7e
to
b057392
Compare
pothos
added a commit
to flatcar/coreos-overlay
that referenced
this pull request
Nov 17, 2020
This pulls in flatcar/init#31 to make extend-filesystems more robust against a race.
dongsupark
approved these changes
Nov 18, 2020
pothos
added a commit
to flatcar/coreos-overlay
that referenced
this pull request
Nov 18, 2020
This pulls in flatcar/init#31 to make extend-filesystems more robust against a race.
jepio
pushed a commit
that referenced
this pull request
Feb 21, 2022
…usage dracut: Stop using deprecated actions in veritysetup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Directly using the device after the resize is prone to races.
At least for the size check it's easy to retry until we succeed getting
the new size. The filesystem resize call may still fail but the service
is limited in this way already because at startup it only checks if the
partition size is maximal but not the filesystem size. For future
debugging the output is made more verbose.
flatcar/Flatcar#235
How to use
Testing done
See flatcar/coreos-overlay#689