Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend-filesystems: More robustness against kernel partition re-reads #31

Merged
merged 1 commit into from Nov 18, 2020

Conversation

pothos
Copy link
Member

@pothos pothos commented Nov 17, 2020

Directly using the device after the resize is prone to races.
At least for the size check it's easy to retry until we succeed getting
the new size. The filesystem resize call may still fail but the service
is limited in this way already because at startup it only checks if the
partition size is maximal but not the filesystem size. For future
debugging the output is made more verbose.

flatcar/Flatcar#235

How to use

Testing done

See flatcar/coreos-overlay#689

@pothos pothos requested a review from a team Nov 17, 2020
Directly using the device after the resize is prone to races.
At least for the size check it's easy to retry until we succeed getting
the new size. The filesystem resize call may still fail but the service
is limited in this way already because at startup it only checks if the
partition size is maximal but not the filesystem size. For future
debugging the output is made more verbose.

flatcar/Flatcar#235
@pothos pothos force-pushed the kai/extend-filesystem-race branch from 85d7b7e to b057392 Compare Nov 17, 2020
pothos added a commit to flatcar/coreos-overlay that referenced this pull request Nov 17, 2020
This pulls in
flatcar/init#31
to make extend-filesystems more robust against a race.
@pothos pothos marked this pull request as ready for review Nov 17, 2020
@pothos pothos merged commit 5b0fdd5 into flatcar-master Nov 18, 2020
@pothos pothos deleted the kai/extend-filesystem-race branch Nov 18, 2020
pothos added a commit to flatcar/coreos-overlay that referenced this pull request Nov 18, 2020
This pulls in
flatcar/init#31
to make extend-filesystems more robust against a race.
jepio pushed a commit that referenced this pull request Feb 21, 2022
…usage

dracut: Stop using deprecated actions in veritysetup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants