Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatcar-install uses lbzip2 if present, falls back on bzip2 if not #46

Merged
merged 1 commit into from
Aug 26, 2021
Merged

flatcar-install uses lbzip2 if present, falls back on bzip2 if not #46

merged 1 commit into from
Aug 26, 2021

Conversation

aniruddha2000
Copy link
Contributor

Check lbzip2 and set it in global variable

Check if lbzip2 is there or not. If yes then set it to a global variable called BZIP_UTIL or if not then set bzip2 to the global variable and use it for further work.

Testing done

Added lbzip2 to the custom Flatcar image and checked with flatcar-install script flatcar-install -d /dev/vdb (with and without the -f flag).

Writing flatcar_production_qemu_image.img.bz2...
Success! Flatcar Container Linux (from flatcar_production_qemu_image.img.bz2) is installed on /dev/vdb

Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you squash the commits (and use the message from the second)?

@aniruddha2000
Copy link
Contributor Author

@pothos yup sure!

Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with sudo ./flatcar-install -s -o "" -C stable on a QEMU VM and it uses lbzip2 when available and otherwise bzip2, thanks.

@pothos pothos merged commit 101e6c7 into flatcar:flatcar-master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants