-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemd/system: run update-ssh-keys once after Ignition #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 1, 2022
This pulls in flatcar/init#66 to fix the problem that Ignition keys would be lost as soon as update-ssh-keys runs. This is done by placing Ignition's keys in as files in the authorized_keys.d folder and calling update-ssh-keys after Ignition ran.
pothos
force-pushed
the
kai/update-ssh-keys-after-ignition
branch
from
April 4, 2022 12:48
aac449d
to
901282d
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 4, 2022
This pulls in flatcar/init#66 to fix the problem that Ignition keys would be lost as soon as update-ssh-keys runs. This is done by placing Ignition's keys in as files in the authorized_keys.d folder and calling update-ssh-keys after Ignition ran.
krnowak
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that no ordering is necessary for the update-ssh-keys-after-ignition.service
unit file, because this stuff will be executed after switching the root, right?
pothos
force-pushed
the
kai/update-ssh-keys-after-ignition
branch
from
April 4, 2022 18:23
901282d
to
3464a3e
Compare
The new Ignition version dropped support for creating the authorized_keys file alongside the authorized_keys.d entry and can only write one of them. Call update-ssh-keys once after Ignition ran, for each user that has the authorized_keys.d folder. Fixes flatcar/Flatcar#699
pothos
force-pushed
the
kai/update-ssh-keys-after-ignition
branch
from
April 4, 2022 18:30
3464a3e
to
1c54411
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 4, 2022
This pulls in flatcar/init#66 to fix the problem that Ignition keys would be lost as soon as update-ssh-keys runs. This is done by placing Ignition's keys in as files in the authorized_keys.d folder and calling update-ssh-keys after Ignition ran.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 4, 2022
This pulls in flatcar/init#66 to fix the problem that Ignition keys would be lost as soon as update-ssh-keys runs. This is done by placing Ignition's keys in as files in the authorized_keys.d folder and calling update-ssh-keys after Ignition ran.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 4, 2022
This pulls in flatcar/init#66 to fix the problem that Ignition keys would be lost as soon as update-ssh-keys runs. This is done by placing Ignition's keys in as files in the authorized_keys.d folder and calling update-ssh-keys after Ignition ran.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Ignition version dropped support for creating the
authorized_keys file alongside the authorized_keys.d entry and can only
write one of them.
Call update-ssh-keys once after Ignition ran, for each user that has
the authorized_keys.d folder.
Fixes flatcar/Flatcar#699
How to use
Test with distro.writeAuthorizedKeysFragment set to the defaul when compiling Ignition
Testing done
Tested the new unit on a VM that booted with keys from Ignition
changelog/
directory (user-facing change, bug fix, security fix, update)↑ in coreos-overlay