flatcar-reset: Add backup and preview #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
reviewed
Mar 28, 2023
rata
reviewed
Mar 29, 2023
When users run flatcar-reset from the command line to try it out, this should not result in data loss when they forget to quote the keep paths correctly or didn't know how to stop the staged reset. Add a warning and the option to see the list of files in preview. Also add the option to do a backup when staging a reset. The backup does not cover ACLs because Flatcar's rsync isn't compiled with support for them.
pothos
force-pushed
the
kai/reset-backup
branch
from
ab13c01 to
fc20edd
Compare
|
I would merge this soon if there are no other comments |
krnowak
approved these changes
Apr 4, 2023
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 4, 2023
This pulls in flatcar/init#94 to prevent data loss by having a preview mode and a backup/restore option.
2 tasks
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 17, 2023
This pulls in flatcar/init#94 to prevent data loss by having a preview mode and a backup/restore option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users run flatcar-reset from the command line to try it out, this should not result in data loss when they forget to quote the keep paths correctly or didn't know how to stop the staged reset. Add a warning and the option to see the list of files in preview. Also add the option to do a backup when staging a reset. The backup does not cover ACLs because Flatcar's rsync isn't compiled with support for them.
How to use
Improve our rsync to support ACLs even though most people don't use them
Testing done
Copied it over manually to a VM at
/home/core/flatcar-reset