From aff274153b5ddf1a9e70d4480cf670aab28ac249 Mon Sep 17 00:00:00 2001 From: Jeremi Piotrowski Date: Fri, 16 Jul 2021 11:41:53 +0000 Subject: [PATCH] kola/test: disable tests that won't work with docker 20.10 These tests are 'docker.oldclient' and 'google.kubernetes.basic.docker.*'. 'docker.oldclient' tries to run docker cli 1.9 against daemon in the image, and fails with: --- FAIL: docker.oldclient (29.22s) cluster.go:117: Error response from daemon: 400 Bad Request: malformed Host header cluster.go:130: "/home/core/docker-1.9.1 run echo echo 'IT WORKED'" failed: output , status Process exited with status 1 This is related to https://github.com/moby/moby/pull/39076, merged into 20.10 which removed some backwards compatibility. The 'google.kubernetes.basic.docker.*' tests fails with the following message in journal: Jul 15 14:17:42.446942 kubelet[4663]: F0715 14:17:42.446505 4663 server.go:274] failed to run Kubelet: misconfiguration: kubelet cgroup driver: "cgroupfs" is different from docker cgroup driver: "systemd" Kubernetes release 1.19 is the first one that properly supports the unified cgroup hierarchy. We also have other tests that test that kubernetes works (kubeadm) so we can disable the legacy ones. The old tests should be removed once the docker 20.10 upgrade has propagated to all channels. See also https://github.com/kinvolk/coreos-overlay/pull/931 Signed-off-by: Jeremi Piotrowski --- kola/tests/docker/docker.go | 3 +++ kola/tests/kubernetes/basic.go | 3 +++ 2 files changed, 6 insertions(+) diff --git a/kola/tests/docker/docker.go b/kola/tests/docker/docker.go index 51a664e9e..4239c26db 100644 --- a/kola/tests/docker/docker.go +++ b/kola/tests/docker/docker.go @@ -26,6 +26,7 @@ import ( "golang.org/x/crypto/ssh" "golang.org/x/net/context" + "github.com/coreos/go-semver/semver" "github.com/coreos/mantle/kola/cluster" "github.com/coreos/mantle/kola/register" "github.com/coreos/mantle/lang/worker" @@ -76,6 +77,8 @@ func init() { Name: "docker.oldclient", Architectures: []string{"amd64"}, Distros: []string{"cl"}, + // incompatible with docker >=20.10 + EndVersion: semver.Version{Major: 2955}, }) register.Register(®ister.Test{ Run: dockerUserns, diff --git a/kola/tests/kubernetes/basic.go b/kola/tests/kubernetes/basic.go index d4b65f04d..bee2c7081 100644 --- a/kola/tests/kubernetes/basic.go +++ b/kola/tests/kubernetes/basic.go @@ -21,6 +21,7 @@ import ( "strings" "time" + "github.com/coreos/go-semver/semver" "github.com/coreos/mantle/kola/cluster" "github.com/coreos/mantle/kola/register" "github.com/coreos/mantle/platform" @@ -54,6 +55,8 @@ func init() { ClusterSize: 0, Platforms: []string{"gce", "do", "aws", "qemu", "azure"}, // TODO: fix packet, esx Distros: []string{"cl"}, + // incompatible with docker >=20.10 + EndVersion: semver.Version{Major: 2955}, }) } }