Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_library: support multi-arch in generate_au_zip #141

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

dongsupark
Copy link
Member

@dongsupark dongsupark commented Aug 12, 2021

To be able to support arm64 native SDK without cross builds, we should make generate_au_zip support both architectures, amd64 and arm64.

Without doing that, build_image fails with ERROR : Required WHITE_LIST items ld-linux-x86-64.so.2 not found!!!, because the script recognizes only amd64 libs in WHITE_LIST.

We should first determine the architecture in build_image, before running generate_au_zip, and pass the architecture, either amd64 or arm64.
Also add allow_list and ld_linux parameters to necessary functions.
Replace black list with deny list, white list with allow list.

How to use

...
./build_image

Testing done

CI passed: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3281/cldsv

Replace black list with deny list, white list with allow list.
@dongsupark dongsupark force-pushed the dongsu/generate-au-multi-arch branch from 8669bba to 0175c1a Compare August 13, 2021 07:31
To be able to support arm64 native SDK without cross builds, we should
make generate_au_zip support both architectures, amd64 and arm64.
Without doing that, `build_image` fails with `ERROR : Required
WHITE_LIST items ld-linux-x86-64.so.2 not found!!!`, because the
script recognizes only amd64 libs in WHITE_LIST.

We should first determine the architecture in build_image, before
running generate_au_zip, and pass the architecture, either amd64 or
arm64. Also add allow_list and ld_linux parameters to necessary
functions.
@dongsupark dongsupark force-pushed the dongsu/generate-au-multi-arch branch from 0175c1a to 34cb6d3 Compare August 13, 2021 08:03
@dongsupark dongsupark marked this pull request as ready for review August 13, 2021 14:55
@dongsupark dongsupark requested a review from a team August 13, 2021 14:55
@dongsupark
Copy link
Member Author

CI passed

Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only spotted some docstring issues.

build_library/generate_au_zip.py Outdated Show resolved Hide resolved
build_library/generate_au_zip.py Show resolved Hide resolved
build_library/generate_au_zip.py Outdated Show resolved Hide resolved
Fix several docstring issues, so that the docstrings could match with
the actual code.
@dongsupark dongsupark merged commit a091274 into main Aug 16, 2021
@dongsupark dongsupark deleted the dongsu/generate-au-multi-arch branch August 16, 2021 14:16
@dongsupark dongsupark moved this from Ready for review to Ready to Release 2021-08-16 in Flatcar Container Linux Releases Planning Aug 16, 2021
@vbatts vbatts removed this from Released 2021-08-16 in Flatcar Container Linux Releases Planning Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants