overlay coreos/config: Keep ldb modules #3478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/19331337841 |
ldb was folded into samba, so it is not sys-libs/ldb that installs ldb modules, but rather net-fs/samba. The ldb modules are needed by sys-auth/sssd to work, so stop removing them in the post src_install hook. Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
krnowak
force-pushed
the
krnowak/fix-sssd
branch
from
c93549c to
deac985
Compare
Member
Author
|
CI passed. |
krnowak
moved this to ✅ Testing / in Review
in Flatcar tactical, release planning, and roadmap
chewi
requested changes
Nov 12, 2025
Contributor
chewi
left a comment
chewi
left a comment
There was a problem hiding this comment.
I think you should therefore drop our sys-libs/ldb package. It's no longer needed and will probably be dropped from Gentoo before long.
github-project-automation
bot
moved this from ✅ Testing / in Review
to ⚒️ In Progress
in Flatcar tactical, release planning, and roadmap
Member
Author
Can I do it in a separate cleanup PR? I think there is more than one package that should be dropped. |
chewi
approved these changes
Nov 12, 2025
github-project-automation
bot
moved this from ⚒️ In Progress
to ✅ Testing / in Review
in Flatcar tactical, release planning, and roadmap
Member
Author
|
(dropping unused packages PR: #3485) |
github-project-automation
bot
moved this from ✅ Testing / in Review
to Implemented
in Flatcar tactical, release planning, and roadmap
Member
Author
|
Pushed to flatcar-4515 (alpha) too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: http://localhost:8080/job/container/job/packages_all_arches/6964/cldsv/
ldb was folded into samba, so it is not sys-libs/ldb that installs ldb modules, but rather net-fs/samba. The ldb modules are needed by sys-auth/sssd to work, so stop removing them in the post src_install hook.
Fixes flatcar/Flatcar#1919
Needs backporting to alpha.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.