Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-apps/acl: Sync with Gentoo to fix crash #809

Merged
merged 3 commits into from
May 11, 2023
Merged

Conversation

jepio
Copy link
Member

@jepio jepio commented May 10, 2023

sys-apps/acl: Sync with Gentoo to fix crash

getacl is currently (main/alpha/beta) failing with a buffer overflow:

  $ getfacl /
  getfacl: Removing leading '/' from absolute path names
  # file: .
  # owner: root
  # group: root
  *** buffer overflow detected ***: terminated
  Aborted (core dumped)

This has been addressed upstream in acl-2.3.1-r1 by lowering FORTIFY_SOURCE level.

I can't reproduce with stable even though stable has the same acl version, so this most likely depends on GCC versions.

Gentoo bug: https://bugs.gentoo.org/847280.
Upstream commit 6273f7c0c37bc0fae7071ec6237654796bdcca55.

How to use

emerge -av sys-apps/acl
getfacl /

Testing done

emerge -av sys-apps/acl
getfacl /
  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

getacl is currently failing with a buffer overflow:

  $ getfacl /
  getfacl: Removing leading '/' from absolute path names
  # file: .
  # owner: root
  # group: root
  *** buffer overflow detected ***: terminated
  Aborted (core dumped)

This has been addressed upstream in acl-2.3.1-r1 by lowering
FORTIFY_SOURCE level.

Upstream commit 6273f7c0c37bc0fae7071ec6237654796bdcca55.

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@jepio jepio requested review from krnowak and a team May 10, 2023 10:18
Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add sys-apps/acl to .github/workflows/portage-stable-packages-list too?

jepio added 2 commits May 10, 2023 15:27
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@jepio
Copy link
Member Author

jepio commented May 10, 2023

Could you please add sys-apps/acl to .github/workflows/portage-stable-packages-list too?

Yes, done.

Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jepio jepio merged commit 0af494c into main May 11, 2023
jepio added a commit that referenced this pull request May 11, 2023
sys-apps/acl: Sync with Gentoo to fix crash
jepio added a commit that referenced this pull request May 11, 2023
sys-apps/acl: Sync with Gentoo to fix crash
@jepio jepio deleted the jepio/acl-coredump-fix branch May 11, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants