-
Notifications
You must be signed in to change notification settings - Fork 4
Support Hardware Security Keys by updating openssh-keys #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the result of "cargo update".
The dead code warning for the "lock" is ignored and the depecration warning for unnecessary "format!" is solved.
This pulls in a newer version of the openssh-keys crate that supports hardware security keys. A test case is added, too.
2 tasks
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Nov 15, 2022
This pulls in flatcar/update-ssh-keys#7 to support Hardware Security Keys in update-ssh-keys.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Nov 15, 2022
This pulls in flatcar/update-ssh-keys#7 to support Hardware Security Keys in update-ssh-keys.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Nov 16, 2022
This pulls in flatcar/update-ssh-keys#7 to support Hardware Security Keys in update-ssh-keys. Until we have a new crates.io release of openssh-keys with coreos/openssh-keys#68 we need to host it on Origin or find a way to make the eclass more flexible.
jepio
approved these changes
Nov 16, 2022
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Nov 16, 2022
This pulls in flatcar/update-ssh-keys#7 to support Hardware Security Keys in update-ssh-keys. Until we have a new crates.io release of openssh-keys with coreos/openssh-keys#68 we need to host it on Origin or find a way to make the eclass more flexible. Here it was hosted on Origin (from "cargo package").
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Nov 16, 2022
This pulls in flatcar/update-ssh-keys#7 to support Hardware Security Keys in update-ssh-keys. Until we have a new crates.io release of openssh-keys with coreos/openssh-keys#68 we need to host it on Origin or find a way to make the eclass more flexible. Here it was hosted on Origin (from "cargo package") and the Cargo.toml/lock patched on build to think it would come from crates.io because the Gentoo eclass only supports that location.
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 17, 2023
This pulls in flatcar/update-ssh-keys#7 to support Hardware Security Keys in update-ssh-keys. Until we have a new crates.io release of openssh-keys with coreos/openssh-keys#68 we need to host it on Origin or find a way to make the eclass more flexible. Here it was hosted on Origin (from "cargo package") and the Cargo.toml/lock patched on build to think it would come from crates.io because the Gentoo eclass only supports that location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Hardware Security Keys by updating openssh-keys
This pulls in a newer version of the openssh-keys crate that supports
hardware security keys. A test case is added, too.
Address compilation warnings
The dead code warning for the "lock" is ignored and the depecration
warning for unnecessary "format!" is solved.
Cargo.lock: Update dependencies
This is the result of "cargo update".
How to use
Use it from coreos-overlay to fix flatcar/Flatcar#691
Testing done
Local
cargo test
Tested with Flatcar Stable by copying binary over (
RUSTFLAGS='-C target-feature=+crt-static' cargo build --target x86_64-unknown-linux-gnu
andscp -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -P 2222 target/x86_64-unknown-linux-gnu/debug/update-ssh-keys core@127.0.0.1:
):Testing with kola: flatcar-archive/coreos-overlay#2289