Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Install dependencies needed by VS Live Share #11

Open
G-Ray opened this issue May 29, 2018 · 4 comments
Open

Install dependencies needed by VS Live Share #11

G-Ray opened this issue May 29, 2018 · 4 comments

Comments

@G-Ray
Copy link

G-Ray commented May 29, 2018

Although tagged as a preview release, VS Live Share is a popular extension. (https://marketplace.visualstudio.com/items?itemName=MS-vsliveshare.vsliveshare)

Do you think we could add the needed dependencies to make it work in this flatpak ?

@G-Ray
Copy link
Author

G-Ray commented May 29, 2018

@amtlib-dot-dll
Copy link
Collaborator

Good idea, if possible can you give a list of how to build these dependencies on flatpak?

  • libunwind
  • lttng-ust
  • libcurl
  • openssl-libs
  • libuuid
  • krb5-libs
  • libicu
  • zlib
  • gnome-keyring
  • libsecret
  • desktop-file-utils

By the way, is the list subject to change?

@devhen
Copy link

devhen commented Jun 13, 2018

It would be awesome to get this working in the VS Code OSS flatpak. In addition to the dependencies, it appears that the extensionAllowedProposedApi in product.json is missing the value ms-vsliveshare.vsliveshare but maybe this would get added during initialization of the extension if the dependencies were there?

See here:
https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/linux#vs-code-oss-issues

@ahayzen
Copy link

ahayzen commented Jan 13, 2019

tl;dr; After adding an extra --talk-name=org.freedesktop.secrets and ignoring library missing warnings, it works \o/

So playing about with this I've found the following...

Dependencies

libunwind               MISSING
lttng-ust               MISSING
libcurl                 runtime (libcurl.so.4.4.0)
openssl-libs            runtime (libssl.so.1.0.2, libssl3.so, libgnutls-openssl.so.27.0.2)
libuuid                 runtime (libuuid.so.1.3.0)
krb5-libs               runtime (libkrb5.so.3.3)
libicu                  runtime (libicu*.so.57.1)
zlib                    runtime (libz.so.1.2.8)
gnome-keyring           ?
libsecret               json (libsecret-1.so.0.0.0)
desktop-file-utils      runtime

I tried adding libunwind to the package, using a similar definition (without the prefix) as [0] this doesn't change the missing libraries warning.

Instead looking at the script which is run [1], one can see that it tries to find apt-get or yum or pacman etc and then eventually fail. I have found if you click install and then ignore the errors one is able to use LiveShare.

However authentications aren't stored (so every time you open a window you have to re-auth), after talking on #flatpak it was suggested to add --talk-name=org.freedesktop.secrets to allow access to the hosts keyring. After doing this VS Code remembers my user and i have been able to successfully do LiveShare assuming I click "Install" to the dependency question and then dismiss the error.

This is the question I get when launching a new window: We were unable to install support for joining sessions using a browser link. You may be missing key Linux libraries. Install them now? I then click "Install" and the following message appears: The dependency installer failed. Try installing dependencies manually. Once I dismiss this LiveShare works.

Note that this text does not match the error at the end of [1], I wonder where it comes from and if we are able to hide/skip it as the dependencies are already installed and working ?

0 - https://github.com/flathub/org.freedesktop.Sdk.Extension.dotnet/blob/69d03f7508e24b03e53ea670b27a8c7a6e7ac126/org.freedesktop.Sdk.Extension.dotnet.yaml#L10
1 - https://raw.githubusercontent.com/MicrosoftDocs/live-share/master/scripts/linux-prereqs.sh

ahayzen added a commit to ahayzen/com.visualstudio.code.oss that referenced this issue Jan 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants