Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Add org.freedesktop.secrets so that LiveShare can talk to gnome-keyri… #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahayzen
Copy link

@ahayzen ahayzen commented Jan 13, 2019

…ng/secrets

This is part of #11

@flathubbot
Copy link

NOTE: This comment was posted by the test instance of buildbot

Started test build 1235

@ahayzen
Copy link
Author

ahayzen commented Jan 13, 2019

If one clicks install when We were unable to install support for joining sessions using a browser link. You may be missing key Linux libraries. Install them now? appears and the ignores The dependency installer failed. Try installing dependencies manually.. LiveShare then works.

I wonder if there is a way to remove or resolve the first message.

@flathubbot
Copy link

NOTE: This comment was posted by the test instance of buildbot

Build 1235 successful
To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/1165/com.visualstudio.code.oss.flatpakref

@amtlib-dot-dll
Copy link
Collaborator

Perhaps LiveShare users can add this as their own override? org.freedesktop.secrets is somehow too sensitive. I think we should add these as documentation in the README file

@ahayzen
Copy link
Author

ahayzen commented Jan 17, 2019

Sure, when I get a moment I'll prepare changes for the README to detail how to get LiveShare working and the --allow=devel option also discussed before.

I do wonder if there is a way we can skip/remove the warnings that come up for LiveShare though 🤔

@gasinvein
Copy link
Member

It's not needed with recent enough libsecret, fd.o runtime and xdg-desktop-portal (on host).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants