Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codes.nora.gDiceRoller Flatpak #1054

Closed
wants to merge 6 commits into from

Conversation

NoraCodes
Copy link

@NoraCodes NoraCodes commented Jun 27, 2019

I'm not sure that all my metadata is in the right place; will the Flatpak be aware of my appdata.xml in the data/ directory of my actual application's repository?

Otherwise, I followed all instructions.

@LeandroStanger
Copy link

@LeandroStanger LeandroStanger commented Jun 27, 2019

bot, build codes.nora.gDiceRoller

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 27, 2019

Queued test build for codes.nora.gDiceRoller.

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 27, 2019

Started test build 4934

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 27, 2019

Build 4934 failed

@NoraCodes
Copy link
Author

@NoraCodes NoraCodes commented Jun 27, 2019

Can't specify build-args in sandboxed build

This is problematic, as it's necessary for Cargo to use the network.

@nedrichards
Copy link
Member

@nedrichards nedrichards commented Jun 28, 2019

@NoraCodes you can't use the network with cargo on flathub, we need all the source code reproducible and archived. However, there are some helpful tools that make that easy!

https://github.com/flatpak/flatpak-builder-tools/tree/master/cargo

could well help! there are also some other examples of rust apps on flathub that use it, have a quick search through the github repo.

@NoraCodes
Copy link
Author

@NoraCodes NoraCodes commented Jun 28, 2019

Understood, thank you @nedrichards . Should be working now.

@bilelmoussaoui
Copy link
Member

@bilelmoussaoui bilelmoussaoui commented Jun 28, 2019

bot, build codes.nora.gDiceRoller

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Queued test build for codes.nora.gDiceRoller.

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Started test build 4944

codes.nora.gDiceRoller.json Outdated Show resolved Hide resolved
],
"command" : "codes.nora.gDiceRoller",
"tags" : [],
"desktop-file-name-suffix" : "",
Copy link
Member

@bilelmoussaoui bilelmoussaoui Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"desktop-file-name-suffix" : "",

codes.nora.gDiceRoller.json Outdated Show resolved Hide resolved
@NoraCodes
Copy link
Author

@NoraCodes NoraCodes commented Jun 28, 2019

stat: cannot stat 'builddir/*/share/app-info/xmls/codes.nora.gDiceRoller.xml.gz': No such file or directory

Ah, this answers my question. This should definitely go in the Flatpak documentation under Desktop Integration, I was wondering about this. Will fix momentarily. Can I ask the bot to run once I've done that, or is that privileged access?

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Build 4944 failed

@NoraCodes
Copy link
Author

@NoraCodes NoraCodes commented Jun 28, 2019

bot, build codes.nora.gDiceRoller

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Queued test build for codes.nora.gDiceRoller.

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Started test build 4945

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Build 4945 failed

@NoraCodes
Copy link
Author

@NoraCodes NoraCodes commented Jun 28, 2019

bot, build codes.nora.gDiceRoller

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Queued test build for codes.nora.gDiceRoller.

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Started test build 4949

@nedrichards
Copy link
Member

@nedrichards nedrichards commented Jun 28, 2019

@NoraCodes you should put the appdata file into /app/share/metainfo/codes.nora.gDiceRoller.appdata.xml it's then compiled by the build process along with the desktop file and icons to make that file you were looking at. Good point about clearer documentation though.

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Build 4949 failed

@NoraCodes
Copy link
Author

@NoraCodes NoraCodes commented Jun 28, 2019

bot, build codes.nora.gDiceRoller

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Queued test build for codes.nora.gDiceRoller.

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Started test build 4950

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Build 4950 failed

@NoraCodes
Copy link
Author

@NoraCodes NoraCodes commented Jun 28, 2019

bot, build codes.nora.gDiceRoller

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Queued test build for codes.nora.gDiceRoller.

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Started test build 4951

@flathubbot
Copy link

@flathubbot flathubbot commented Jun 28, 2019

Build 4951 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/4742/codes.nora.gDiceRoller.flatpakref

@nedrichards
Copy link
Member

@nedrichards nedrichards commented Jun 28, 2019

Repository has been created: https://github.com/flathub/codes.nora.gDiceRoller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants