Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.salutatoi.Cagou #1115

Open
wants to merge 4 commits into
base: new-pr
from

Conversation

@goffi-contrib
Copy link

commented Aug 15, 2019

Cagou is the desktop/mobiles frontend of Salut à Toi. Salut à Toi is an
advanced XMPP client offering features such as end-to-end encryption
(OTR + OMEMO), file sharing, remote controls, etc.

Add org.salutatoi.Cagou
Cagou is the desktop/mobiles frontend of Salut à Toi. Salut à Toi is an
advanced XMPP client offering features such as end-to-end encryption
(OTR + OMEMO), file sharing, remote controls, etc.
org.salutatoi.Cagou.json Outdated Show resolved Hide resolved
"--filesystem=home"
],
"modules": [
{

This comment has been minimized.

Copy link
@barthalion

This comment has been minimized.

Copy link
@goffi-contrib

goffi-contrib Aug 17, 2019

Author

I have seen indeed, but after doing that one unfortunately. I'll update to use the official one.

]
},
{
"name": "libxslt",

This comment has been minimized.

Copy link
@barthalion

barthalion Aug 16, 2019

Member

All modules likely need some cleanups to delete development headers (etc.).

This comment has been minimized.

Copy link
@goffi-contrib

goffi-contrib Aug 17, 2019

Author

I'll try to review non python modules to see what I can remove.

org.salutatoi.Cagou.json Show resolved Hide resolved
@@ -0,0 +1,58 @@
<?xml version='1.0' encoding='utf-8'?>

This comment has been minimized.

Copy link
@barthalion

barthalion Aug 16, 2019

Member

Desktop and appdata files ideally should be part of upstream repositories and installed by project buildsystem if possible – other distributions are also using them.

This comment has been minimized.

Copy link
@goffi-contrib

goffi-contrib Aug 17, 2019

Author

Indeed. Next version will be Python 3 only and I've done many changes already, I'll add those script upstream for the next version, but I rather keep them here for this 0.7.0 version.

@barthalion

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

bot, build org.salutatoi.Cagou

@flathubbot

This comment has been minimized.

Copy link

commented Aug 16, 2019

Queued test build for org.salutatoi.Cagou.

@flathubbot

This comment has been minimized.

Copy link

commented Aug 16, 2019

Started test build 6716

@flathubbot

This comment has been minimized.

Copy link

commented Aug 16, 2019

Build 6716 failed

@goffi-contrib

This comment has been minimized.

Copy link
Author

commented Aug 17, 2019

Hello, thank for your review. I'll address the comments individually and make an update as soon as possible (quite busy right now).

updated manifest according to review
- removed "defaul-branch"
- use flathub shared-modules for Python 2
- removed libxslt has it is in freedesktop runtime
- use Twisted 19.2.1 (latest one being causing trouble)
@goffi-contrib

This comment has been minimized.

Copy link
Author

commented Aug 23, 2019

bot, build org.salutatoi.Cagou

@flathubbot

This comment has been minimized.

Copy link

commented Aug 23, 2019

Queued test build for org.salutatoi.Cagou.

@flathubbot

This comment has been minimized.

Copy link

commented Aug 23, 2019

Started test build 6933

@goffi-contrib

This comment has been minimized.

Copy link
Author

commented Aug 23, 2019

@barthalion following your review, I've removed the branch, used flathub's shared-modules for python2, and removed libxslt after realizing it was in freedesktop runtime. I've also updated appdata file with content_rating as it was making the first test build fail.

I'm not sure why build are failing on non x86_64 platforms, Pillow complains that The headers or library files could not be found for zlib but zlib should be in freedesktop SDK right?

Let me know if there is anything else to change, thanks you :)

@flathubbot

This comment has been minimized.

Copy link

commented Aug 23, 2019

Build 6933 failed

@nedrichards

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

bot, build org.salutatoi.Cagou

@flathubbot

This comment has been minimized.

Copy link

commented Aug 23, 2019

Queued test build for org.salutatoi.Cagou.

@flathubbot

This comment has been minimized.

Copy link

commented Aug 23, 2019

Started test build 6940

@flathubbot

This comment has been minimized.

Copy link

commented Aug 23, 2019

Build 6940 failed

@LeandroStanger

This comment has been minimized.

Copy link

commented Aug 25, 2019

bot, build org.salutatoi.Cagou

@flathubbot

This comment has been minimized.

Copy link

commented Aug 25, 2019

Queued test build for org.salutatoi.Cagou.

@flathubbot

This comment has been minimized.

Copy link

commented Aug 25, 2019

Started test build 6975

@flathubbot

This comment has been minimized.

Copy link

commented Aug 25, 2019

Build 6975 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.