Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.vscodium.codium #1433

Closed
wants to merge 6 commits into from
Closed

Conversation

noonsleeper
Copy link

@noonsleeper noonsleeper commented Mar 31, 2020

This repo is heavily based on Visual Studio Code flatpak repo
https://github.com/flathub/com.visualstudio.code

This repo is heavily based on Visual Studio Code flatpak repo
https://github.com/flathub/com.visualstudio.code
flathub.json Outdated Show resolved Hide resolved
com.vscodium.codium.yaml Outdated Show resolved Hide resolved
@LeandroStanger
Copy link

@LeandroStanger LeandroStanger commented Mar 31, 2020

bot, build com.vscodium.codium

@flathubbot
Copy link

@flathubbot flathubbot commented Mar 31, 2020

Queued test build for com.vscodium.codium.

@flathubbot
Copy link

@flathubbot flathubbot commented Mar 31, 2020

Started test build 17730

@flathubbot
Copy link

@flathubbot flathubbot commented Mar 31, 2020

Build 17730 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/16991/com.vscodium.codium.flatpakref

@nedrichards
Copy link
Member

@nedrichards nedrichards commented Mar 31, 2020

How exactly is this different to the OSS VS Code build https://github.com/flathub/com.visualstudio.code.oss ?

@noonsleeper
Copy link
Author

@noonsleeper noonsleeper commented Mar 31, 2020

How exactly is this different to the OSS VS Code build https://github.com/flathub/com.visualstudio.code.oss ?

The code on https://github.com/flathub/com.visualstudio.code.oss is a build from vscode sources and sadly I don't have enough spare time to figured how to resolve any compilation time bug also flathub/com.visualstudio.code.oss#46 is up to 7 month open.
I only repackage vscodium.com's deb in the same way as flatpak's vscode build is made to take advantage of all the good things on flatpak.

@noonsleeper
Copy link
Author

@noonsleeper noonsleeper commented Apr 4, 2020

hey guys any news about this?

@bilelmoussaoui
Copy link
Member

@bilelmoussaoui bilelmoussaoui commented Apr 4, 2020

Have you reached out to the upstream maintainer if they wanted to (co-)maintain the flatpak package?

@noonsleeper
Copy link
Author

@noonsleeper noonsleeper commented Apr 4, 2020

hi! if you're asking me for the vscodium maintainer's permissions I have it =)
I sent an email to him asking for his permissions

@stripedpajamas
Copy link

@stripedpajamas stripedpajamas commented Apr 4, 2020

Maintainer of VSCodium here-- I don't have capacity to maintain the flatpak version myself, but would be happy to help @noonsleeper etc whenever/however.

@@ -0,0 +1,18 @@
[Desktop Entry]
Name=VSCodium
Comment=Code Editing. Redefined.
Copy link
Member

@bilelmoussaoui bilelmoussaoui Apr 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The desktop file & metainfo should be ideally upstreamed.

Copy link
Author

@noonsleeper noonsleeper Apr 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bilelmoussaoui, thanks for the review. I'll suggest this to @stripedpajamas

com.vscodium.codium.yaml Outdated Show resolved Hide resolved
@bilelmoussaoui bilelmoussaoui changed the title Add Support for VsCodium Add com.vscodium.codium Apr 4, 2020
@bilelmoussaoui
Copy link
Member

@bilelmoussaoui bilelmoussaoui commented Apr 7, 2020

bot, build com.vscodium.codium

@flathubbot
Copy link

@flathubbot flathubbot commented Apr 7, 2020

Queued test build for com.vscodium.codium.

@flathubbot
Copy link

@flathubbot flathubbot commented Apr 7, 2020

Started test build 18044

@flathubbot
Copy link

@flathubbot flathubbot commented Apr 7, 2020

Build 18044 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17299/com.vscodium.codium.flatpakref

Name=VSCodium
Comment=Code Editing. Redefined.
GenericName=Text Editor
Exec=codium --no-sandbox --unity-launch --reuse-window %F
Copy link
Member

@bilelmoussaoui bilelmoussaoui Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use zypak instead of --no-sandbox.

Copy link
Member

@barthalion barthalion Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note it's already included in the base app so you just need to change this line to use zypak-wrapper. Example app: https://github.com/flathub/com.microsoft.Teams

Copy link
Author

@noonsleeper noonsleeper Apr 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! sorry for the late response recently at my job the amount work has increased. @bilelmoussaoui I applied your suggestion, thanks for the link @barthalion. Also I update package to the latest version of the Codium.

@barthalion
Copy link
Member

@barthalion barthalion commented Apr 27, 2020

bot, build com.vscodium.codium

@flathubbot
Copy link

@flathubbot flathubbot commented Apr 27, 2020

Queued test build for com.vscodium.codium.

@flathubbot
Copy link

@flathubbot flathubbot commented Apr 27, 2020

Started test build 19069

@flathubbot
Copy link

@flathubbot flathubbot commented Apr 27, 2020

Build 19069 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/18282/com.vscodium.codium.flatpakref

Copy link
Member

@barthalion barthalion left a comment

Have you contacted upstream team about publishing their application on Flathub?

runtime-version: '19.08'
sdk: org.freedesktop.Sdk
command: codium
desktop-file-name-suffix: ' (Flatpak)'
Copy link
Member

@barthalion barthalion Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand you want to differentiate it but I don't think it's the way to go.

Copy link
Author

@noonsleeper noonsleeper Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh no! I miss that change, let me fix that.

Copy link
Author

@noonsleeper noonsleeper Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you contacted upstream team about publishing their application on Flathub?

Yes, @stripedpajamas is the developer of VSCodium

Maintainer of VSCodium here-- I don't have capacity to maintain the flatpak version myself, but would be happy to help @noonsleeper etc whenever/however.

@barthalion
Copy link
Member

@barthalion barthalion commented May 4, 2020

FYI @stripedpajamas, I'm going to add you to maintainers as well, just in case you want to change something yourself.

/merge @stripedpajamas

@flathubbot
Copy link

@flathubbot flathubbot commented May 4, 2020

A repository for this has been created: https://github.com/flathub/com.vscodium.codium

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants