Add com.vscodium.codium #1433
Add com.vscodium.codium #1433
Conversation
This repo is heavily based on Visual Studio Code flatpak repo https://github.com/flathub/com.visualstudio.code
|
bot, build com.vscodium.codium |
|
Queued test build for com.vscodium.codium. |
|
Started test build 17730 |
|
Build 17730 successful |
|
How exactly is this different to the OSS VS Code build https://github.com/flathub/com.visualstudio.code.oss ? |
The code on https://github.com/flathub/com.visualstudio.code.oss is a build from vscode sources and sadly I don't have enough spare time to figured how to resolve any compilation time bug also flathub/com.visualstudio.code.oss#46 is up to 7 month open. |
|
hey guys any news about this? |
|
Have you reached out to the upstream maintainer if they wanted to (co-)maintain the flatpak package? |
|
hi! if you're asking me for the vscodium maintainer's permissions I have it =) |
|
Maintainer of VSCodium here-- I don't have capacity to maintain the flatpak version myself, but would be happy to help @noonsleeper etc whenever/however. |
| @@ -0,0 +1,18 @@ | |||
| [Desktop Entry] | |||
| Name=VSCodium | |||
| Comment=Code Editing. Redefined. | |||
There was a problem hiding this comment.
The desktop file & metainfo should be ideally upstreamed.
There was a problem hiding this comment.
@bilelmoussaoui, thanks for the review. I'll suggest this to @stripedpajamas
|
bot, build com.vscodium.codium |
|
Queued test build for com.vscodium.codium. |
|
Started test build 18044 |
|
Build 18044 successful |
com.vscodium.codium.desktop
Outdated
| Name=VSCodium | ||
| Comment=Code Editing. Redefined. | ||
| GenericName=Text Editor | ||
| Exec=codium --no-sandbox --unity-launch --reuse-window %F |
There was a problem hiding this comment.
You should use zypak instead of --no-sandbox.
There was a problem hiding this comment.
Note it's already included in the base app so you just need to change this line to use zypak-wrapper. Example app: https://github.com/flathub/com.microsoft.Teams
There was a problem hiding this comment.
hey! sorry for the late response recently at my job the amount work has increased. @bilelmoussaoui I applied your suggestion, thanks for the link @barthalion. Also I update package to the latest version of the Codium.
|
bot, build com.vscodium.codium |
|
Queued test build for com.vscodium.codium. |
|
Started test build 19069 |
|
Build 19069 successful |
Have you contacted upstream team about publishing their application on Flathub?
com.vscodium.codium.yaml
Outdated
| runtime-version: '19.08' | ||
| sdk: org.freedesktop.Sdk | ||
| command: codium | ||
| desktop-file-name-suffix: ' (Flatpak)' |
There was a problem hiding this comment.
I understand you want to differentiate it but I don't think it's the way to go.
There was a problem hiding this comment.
ohh no! I miss that change, let me fix that.
There was a problem hiding this comment.
Have you contacted upstream team about publishing their application on Flathub?
Yes, @stripedpajamas is the developer of VSCodium
Maintainer of VSCodium here-- I don't have capacity to maintain the flatpak version myself, but would be happy to help @noonsleeper etc whenever/however.
|
FYI @stripedpajamas, I'm going to add you to maintainers as well, just in case you want to change something yourself. /merge @stripedpajamas |
|
A repository for this has been created: https://github.com/flathub/com.vscodium.codium You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you have never maintained an application before, common questions are answered in the app maintenance guide. Thanks! |
This repo is heavily based on Visual Studio Code flatpak repo
https://github.com/flathub/com.visualstudio.code