Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.freeplane.App #1440

Closed
wants to merge 11 commits into from
Closed

Add org.freeplane.App #1440

wants to merge 11 commits into from

Conversation

olea
Copy link

@olea olea commented Apr 7, 2020

No description provided.

org.freeplane.App.appdata.xml Outdated Show resolved Hide resolved
- type: file
path: org.freeplane.App.appdata.xml
- type: shell
commands:
Copy link
Member

@bilelmoussaoui bilelmoussaoui Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use post-install to install the metainfo/icon/desktop files

@olea
Copy link
Author

olea commented Apr 7, 2020

Changes pushed.


# Install AppData.
- type: file
path: org.freeplane.App.appdata.xml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New appdata files should use metainfo instead. https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html

@LeandroStanger
Copy link

LeandroStanger commented Apr 7, 2020

bot, build org.freeplane.App

@flathubbot
Copy link

flathubbot commented Apr 7, 2020

Queued test build for org.freeplane.App.

@flathubbot
Copy link

flathubbot commented Apr 7, 2020

Started test build 18082

@flathubbot
Copy link

flathubbot commented Apr 7, 2020

Build 18082 failed

- full URL for screenshots
@olea
Copy link
Author

olea commented Apr 7, 2020

bot, build org.freeplane.App

@flathubbot
Copy link

flathubbot commented Apr 7, 2020

Queued test build for org.freeplane.App.

@flathubbot
Copy link

flathubbot commented Apr 7, 2020

Started test build 18087

@flathubbot
Copy link

flathubbot commented Apr 7, 2020

Build 18087 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17341/org.freeplane.App.flatpakref

@LeandroStanger
Copy link

LeandroStanger commented Apr 8, 2020

bot, build org.freeplane.App

1 similar comment
@olea
Copy link
Author

olea commented Apr 9, 2020

bot, build org.freeplane.App

@flathubbot
Copy link

flathubbot commented Apr 9, 2020

Queued test build for org.freeplane.App.

@flathubbot
Copy link

flathubbot commented Apr 9, 2020

Started test build 18182

@flathubbot
Copy link

flathubbot commented Apr 9, 2020

Build 18182 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17436/org.freeplane.App.flatpakref

@olea
Copy link
Author

olea commented Apr 9, 2020

bot, build org.freeplane.App

@flathubbot
Copy link

flathubbot commented Apr 9, 2020

Queued test build for org.freeplane.App.

@flathubbot
Copy link

flathubbot commented Apr 9, 2020

Started test build 18185

@flathubbot
Copy link

flathubbot commented Apr 9, 2020

Build 18185 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17439/org.freeplane.App.flatpakref


<update_contact>ismael@olea.org</update_contact>

<content_rating type="oars-1.1">
Copy link
Member

@barthalion barthalion Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be replaced with <content_rating type="oars-1.1" />.

- --share=network
- --device=dri
- --filesystem=home
- --allow=multiarch
Copy link
Member

@barthalion barthalion Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it needed for?

Copy link
Author

@olea olea Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the multiarch thing? I though it was convenient for java multiplatform apps but seems I was wrong.

url: https://sourceforge.net/projects/freeplane/files/freeplane%20stable/freeplane_bin-1.8.1.zip
sha256: faae9cd9fd5a7fc19057737d1c3cf3d107c11b8b8d9f9b59069c95d9d7d5f673

- type: file
Copy link
Member

@barthalion barthalion Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use buildsystem: simple instead and define build-commands array.

Copy link
Author

@olea olea Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, you prefer not to use an external Makefile, right?

@@ -0,0 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

@barthalion barthalion Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be upstreamed.

@@ -0,0 +1,102 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

@barthalion barthalion Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be upstreamed.

Copy link
Author

@olea olea Apr 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- --socket=x11
- --socket=wayland
- --socket=pulseaudio
- --share=network
Copy link
Member

@barthalion barthalion Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is network access required?

Copy link
Author

@olea olea Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering, for example, you could embed URIs into the mindmaps I guess it does.

@barthalion
Copy link
Member

barthalion commented Apr 9, 2020

Have you contacted upstream team if they would be interested in (co-)maintaining their app on Flathub?

@olea
Copy link
Author

olea commented Apr 9, 2020

Have you contacted upstream team if they would be interested in (co-)maintaining their app on Flathub?

I'll propose it to them as soon I have an approved package.

@olea
Copy link
Author

olea commented Apr 12, 2020

bot, build org.freeplane.App

@flathubbot
Copy link

flathubbot commented Apr 12, 2020

Queued test build for org.freeplane.App.

@flathubbot
Copy link

flathubbot commented Apr 12, 2020

Started test build 18326

@nedrichards
Copy link
Member

nedrichards commented Apr 12, 2020

Have you contacted upstream team if they would be interested in (co-)maintaining their app on Flathub?

I'll propose it to them as soon I have an approved package.

We generally find it saves time and effort to do this earlier, since upstream input may involve changing some things again (e.g. they may have a different view on app-id etc.)

@flathubbot
Copy link

flathubbot commented Apr 12, 2020

Build 18326 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17568/org.freeplane.App.flatpakref

@olea
Copy link
Author

olea commented Apr 12, 2020

bot, build org.freeplane.App

@flathubbot
Copy link

flathubbot commented Apr 12, 2020

Queued test build for org.freeplane.App.

@flathubbot
Copy link

flathubbot commented Apr 12, 2020

Started test build 18342

@flathubbot
Copy link

flathubbot commented Apr 12, 2020

Build 18342 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17584/org.freeplane.App.flatpakref

@olea
Copy link
Author

olea commented Apr 12, 2020

We generally find it saves time and effort to do this earlier, since upstream input may involve changing some things again (e.g. they may have a different view on app-id etc.)

I've just emailed @dpolivaev (main maintainer) with details.

@olea
Copy link
Author

olea commented Apr 13, 2020

Have you contacted upstream team if they would be interested in (co-)maintaining their app on Flathub?

I'll propose it to them as soon I have an approved package.

We generally find it saves time and effort to do this earlier, since upstream input may involve changing some things again (e.g. they may have a different view on app-id etc.)

org.freeplane.App.metainfo.xml has been accepted by upstream: freeplane/freeplane@99a8fd8

FYI

@bilelmoussaoui bilelmoussaoui changed the title Flatpak package for Freeplane Add org.freeplane.App Apr 23, 2020
buildsystem: simple
build-commands:
- mkdir -p /app/Freeplane /app/bin
- cp -ra freeplane-1.8.2/* /app/Freeplane
Copy link
Member

@barthalion barthalion Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: you probably want to use a regex here instead of a version just to avoid the burden of changing it in multiple places.

Copy link
Author

@olea olea Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean regex or wildcards?

Anyhow, the version number is used two times: here and at the git branch tag, so manifest needs to be updated by hand in any case.

@barthalion
Copy link
Member

barthalion commented Apr 27, 2020

@olea Any news on upstream involvement? If you open an issue on the project's Github as well so I can subscribe there, I think it's good to merge.

@olea
Copy link
Author

olea commented Apr 27, 2020

@olea Any news on upstream involvement? If you open an issue on the project's Github as well so I can subscribe there, I think it's good to merge.

The metainfo file has been accepted, but there has not been new stable release so I didn't updated the manifest.

@barthalion
Copy link
Member

barthalion commented May 4, 2020

@olea Any news on upstream involvement? If you open an issue on the project's Github as well so I can subscribe there, I think it's good to merge.

The metainfo file has been accepted, but there has not been new stable release so I didn't updated the manifest.

What I mean is, is anyone from upstream team interested in co-maintaining the app on Flathub?

@olea
Copy link
Author

olea commented May 4, 2020

What I mean is, is anyone from upstream team interested in co-maintaining the app on Flathub?

I can't say.

Hi @dpolivaev, sorry to ask: how do you see it?

@dpolivaev
Copy link

dpolivaev commented May 4, 2020

@olea What do you mean by co-maintaining the app?

@olea
Copy link
Author

olea commented May 4, 2020

@olea What do you mean by co-maintaining the app?

Flathub admins asks for someone upstream to be able of updating the Flatpak build of Freeplane if needed.

At this point it would be very easy to do because is just updating a version number in a file and clicking to rebuild at the flathub CI.

My intention is to do the job myself without extra help, anyway.

@dpolivaev
Copy link

dpolivaev commented May 4, 2020

That's fine.
If you need any help with Freeplane you can hit me again.

@bilelmoussaoui
Copy link
Member

bilelmoussaoui commented May 4, 2020

/merge @dpolivaev

@flathubbot
Copy link

flathubbot commented May 4, 2020

A repository for this has been created: https://github.com/flathub/org.freeplane.App

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants