Add org.freeplane.App #1440

olea · 2020-04-07T20:56:28Z

No description provided.

org.freeplane.App.appdata.xml

bilelmoussaoui · 2020-04-07T21:12:41Z

org.freeplane.App.yml

+      - type: file
+        path: org.freeplane.App.appdata.xml
+      - type: shell
+        commands:


Just use post-install to install the metainfo/icon/desktop files

olea · 2020-04-07T22:02:01Z

Changes pushed.

flathubbot · 2020-04-07T22:43:11Z

Queued test build for org.freeplane.App.

flathubbot · 2020-04-07T22:43:48Z

Started test build 18082

flathubbot · 2020-04-07T22:46:14Z

Build 18082 failed

- full URL for screenshots

olea · 2020-04-07T23:20:12Z

bot, build org.freeplane.App

flathubbot · 2020-04-07T23:20:13Z

Queued test build for org.freeplane.App.

flathubbot · 2020-04-07T23:20:32Z

Started test build 18087

flathubbot · 2020-04-07T23:22:47Z

Build 18087 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17341/org.freeplane.App.flatpakref

olea · 2020-04-09T07:16:40Z

bot, build org.freeplane.App

flathubbot · 2020-04-09T07:16:41Z

Queued test build for org.freeplane.App.

flathubbot · 2020-04-09T07:16:59Z

Started test build 18182

flathubbot · 2020-04-09T07:19:30Z

Build 18182 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17436/org.freeplane.App.flatpakref

olea · 2020-04-09T08:23:28Z

bot, build org.freeplane.App

flathubbot · 2020-04-09T08:23:31Z

Queued test build for org.freeplane.App.

flathubbot · 2020-04-09T08:23:45Z

Started test build 18185

flathubbot · 2020-04-09T08:25:54Z

Build 18185 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17439/org.freeplane.App.flatpakref

barthalion · 2020-04-09T09:55:46Z

org.freeplane.App.metainfo.xml

+
+  <update_contact>ismael@olea.org</update_contact>
+
+  <content_rating type="oars-1.1">


This can be replaced with <content_rating type="oars-1.1" />.

barthalion · 2020-04-09T09:56:21Z

org.freeplane.App.yml

+  - --share=network
+  - --device=dri
+  - --filesystem=home
+  - --allow=multiarch


What is it needed for?

You mean the multiarch thing? I though it was convenient for java multiplatform apps but seems I was wrong.

barthalion · 2020-04-09T09:56:57Z

org.freeplane.App.yml

+        url: https://sourceforge.net/projects/freeplane/files/freeplane%20stable/freeplane_bin-1.8.1.zip
+        sha256: faae9cd9fd5a7fc19057737d1c3cf3d107c11b8b8d9f9b59069c95d9d7d5f673
+
+      - type: file


Use buildsystem: simple instead and define build-commands array.

so, you prefer not to use an external Makefile, right?

barthalion · 2020-04-09T09:57:15Z

org.freeplane.App.mime.xml

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>


It should be upstreamed.

barthalion · 2020-04-09T09:57:24Z

org.freeplane.App.metainfo.xml

@@ -0,0 +1,102 @@
+<?xml version="1.0" encoding="UTF-8"?>


It should be upstreamed.

freeplane/freeplane#157

barthalion · 2020-04-09T09:57:58Z

org.freeplane.App.yml

+  - --socket=x11
+  - --socket=wayland
+  - --socket=pulseaudio
+  - --share=network


Is network access required?

Considering, for example, you could embed URIs into the mindmaps I guess it does.

barthalion · 2020-04-09T09:59:07Z

Have you contacted upstream team if they would be interested in (co-)maintaining their app on Flathub?

olea · 2020-04-09T10:11:26Z

Have you contacted upstream team if they would be interested in (co-)maintaining their app on Flathub?

I'll propose it to them as soon I have an approved package.

olea · 2020-04-12T12:38:07Z

bot, build org.freeplane.App

flathubbot · 2020-04-12T12:38:08Z

Queued test build for org.freeplane.App.

flathubbot · 2020-04-12T12:38:26Z

Started test build 18326

nedrichards · 2020-04-12T12:45:26Z

Have you contacted upstream team if they would be interested in (co-)maintaining their app on Flathub?

I'll propose it to them as soon I have an approved package.

We generally find it saves time and effort to do this earlier, since upstream input may involve changing some things again (e.g. they may have a different view on app-id etc.)

flathubbot · 2020-04-12T12:47:33Z

Build 18326 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17568/org.freeplane.App.flatpakref

olea · 2020-04-12T18:31:25Z

bot, build org.freeplane.App

flathubbot · 2020-04-12T18:31:27Z

Queued test build for org.freeplane.App.

flathubbot · 2020-04-12T18:31:55Z

Started test build 18342

flathubbot · 2020-04-12T18:34:19Z

Build 18342 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17584/org.freeplane.App.flatpakref

olea · 2020-04-12T18:40:46Z

We generally find it saves time and effort to do this earlier, since upstream input may involve changing some things again (e.g. they may have a different view on app-id etc.)

I've just emailed @dpolivaev (main maintainer) with details.

olea · 2020-04-13T19:25:46Z

Have you contacted upstream team if they would be interested in (co-)maintaining their app on Flathub?

I'll propose it to them as soon I have an approved package.

We generally find it saves time and effort to do this earlier, since upstream input may involve changing some things again (e.g. they may have a different view on app-id etc.)

org.freeplane.App.metainfo.xml has been accepted by upstream: freeplane/freeplane@99a8fd8

FYI

barthalion · 2020-04-27T08:51:00Z

org.freeplane.App.yml

+    buildsystem: simple
+    build-commands: 
+      - mkdir -p /app/Freeplane /app/bin
+      - cp -ra freeplane-1.8.2/* /app/Freeplane


Nitpick: you probably want to use a regex here instead of a version just to avoid the burden of changing it in multiple places.

You mean regex or wildcards?

Anyhow, the version number is used two times: here and at the git branch tag, so manifest needs to be updated by hand in any case.

barthalion · 2020-04-27T08:52:08Z

@olea Any news on upstream involvement? If you open an issue on the project's Github as well so I can subscribe there, I think it's good to merge.

olea · 2020-04-27T09:19:59Z

@olea Any news on upstream involvement? If you open an issue on the project's Github as well so I can subscribe there, I think it's good to merge.

The metainfo file has been accepted, but there has not been new stable release so I didn't updated the manifest.

barthalion · 2020-05-04T08:13:30Z

@olea Any news on upstream involvement? If you open an issue on the project's Github as well so I can subscribe there, I think it's good to merge.

The metainfo file has been accepted, but there has not been new stable release so I didn't updated the manifest.

What I mean is, is anyone from upstream team interested in co-maintaining the app on Flathub?

olea · 2020-05-04T15:35:56Z

What I mean is, is anyone from upstream team interested in co-maintaining the app on Flathub?

I can't say.

Hi @dpolivaev, sorry to ask: how do you see it?

dpolivaev · 2020-05-04T15:39:01Z

@olea What do you mean by co-maintaining the app?

olea · 2020-05-04T15:46:09Z

@olea What do you mean by co-maintaining the app?

Flathub admins asks for someone upstream to be able of updating the Flatpak build of Freeplane if needed.

At this point it would be very easy to do because is just updating a version number in a file and clicking to rebuild at the flathub CI.

My intention is to do the job myself without extra help, anyway.

dpolivaev · 2020-05-04T15:48:14Z

That's fine.
If you need any help with Freeplane you can hit me again.

bilelmoussaoui · 2020-05-04T15:55:57Z

/merge @dpolivaev

flathubbot · 2020-05-04T15:57:41Z

A repository for this has been created: https://github.com/flathub/org.freeplane.App

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

Flatpak package for Freeplane

73ceef5

bilelmoussaoui reviewed Apr 7, 2020

View reviewed changes

org.freeplane.App.appdata.xml Outdated Show resolved Hide resolved

bilelmoussaoui reviewed Apr 7, 2020

View reviewed changes

Modifications after flathub review.

cf8d0c6

- Changing from appdata to metainfo

5da0bf3

- full URL for screenshots

olea added 2 commits April 8, 2020 20:25

Correct format for the license.

e31203d

fixing path for using JRE only

eb613c7

Making appstream-util validate happier.

4117c9e

barthalion reviewed Apr 9, 2020

View reviewed changes

olea added 3 commits April 10, 2020 13:24

changes suggested by Flathub reviewers

b1bc4c1

cleaning stuff

0f573d6

cleaning more stuff

1078c95

this mime file is not used anymore

c207364

1.8.2 released

7912dbb

bilelmoussaoui changed the title ~~Flatpak package for Freeplane~~ Add org.freeplane.App Apr 23, 2020

barthalion reviewed Apr 27, 2020

View reviewed changes

nedrichards added the awaiting-upstream Pull request waiting for inputs or changes from author label May 3, 2020

flathubbot closed this May 4, 2020


		<update_contact>ismael@olea.org</update_contact>

		<content_rating type="oars-1.1">

Add org.freeplane.App #1440

Add org.freeplane.App #1440

Conversation

olea commented Apr 7, 2020

Choose a reason for hiding this comment

olea commented Apr 7, 2020

flathubbot commented Apr 7, 2020

flathubbot commented Apr 7, 2020

flathubbot commented Apr 7, 2020

olea commented Apr 7, 2020

flathubbot commented Apr 7, 2020

flathubbot commented Apr 7, 2020

flathubbot commented Apr 7, 2020

olea commented Apr 9, 2020

flathubbot commented Apr 9, 2020

flathubbot commented Apr 9, 2020

flathubbot commented Apr 9, 2020

olea commented Apr 9, 2020

flathubbot commented Apr 9, 2020

flathubbot commented Apr 9, 2020

flathubbot commented Apr 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

barthalion commented Apr 9, 2020

olea commented Apr 9, 2020

olea commented Apr 12, 2020

flathubbot commented Apr 12, 2020

flathubbot commented Apr 12, 2020

nedrichards commented Apr 12, 2020

flathubbot commented Apr 12, 2020

olea commented Apr 12, 2020

flathubbot commented Apr 12, 2020

flathubbot commented Apr 12, 2020

flathubbot commented Apr 12, 2020

olea commented Apr 12, 2020

olea commented Apr 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

barthalion commented Apr 27, 2020

olea commented Apr 27, 2020

barthalion commented May 4, 2020

olea commented May 4, 2020

dpolivaev commented May 4, 2020

olea commented May 4, 2020

dpolivaev commented May 4, 2020

bilelmoussaoui commented May 4, 2020

flathubbot commented May 4, 2020