Add md.obsidian.Obsidian (Obsidian) #1883

joshua-stone · 2020-10-11T17:37:40Z

This PR should fulfill a feature request made on the Obsidian community forum:

https://forum.obsidian.md/t/linux-packaging-ship-as-flatpak-on-flathub/6112

Note: I'm not one of the upstream developers.

nedrichards · 2020-10-11T18:26:01Z

bot, build md.obsidian.Obsidian

flathubbot · 2020-10-11T18:26:02Z

Queued test build for md.obsidian.Obsidian.

flathubbot · 2020-10-11T18:26:16Z

Started test build 30102

flathubbot · 2020-10-11T18:27:15Z

Build 30102 failed

joshua-stone · 2020-10-11T21:56:52Z

I've changed the flatpak to use the tarball instead of the appimage, which hopefully will let the build succeed this time.

barthalion · 2020-10-12T06:39:15Z

bot, build md.obsidian.Obsidian

flathubbot · 2020-10-12T06:39:16Z

Queued test build for md.obsidian.Obsidian.

flathubbot · 2020-10-12T06:39:29Z

Started test build 30136

flathubbot · 2020-10-12T06:40:29Z

Build 30136 failed

barthalion · 2020-10-12T06:47:22Z

Build failed due to missing appdata file:

stat: cannot stat 'builddir/*/share/app-info/xmls/md.obsidian.Obsidian.xml.gz': No such file or directory

md.obsidian.Obsidian.appdata.xml

barthalion · 2020-10-12T06:54:07Z

md.obsidian.Obsidian.appdata.xml

+  <name>Obsidian</name>
+  <summary>Markdown-based knowledge base</summary>
+  <description>
+    <p>Obsidian is a powerful knowledge base that works on top of a local folder of plain text Markdown files.</p>


Could the description be expanded upon to include what the homepage says?

md.obsidian.Obsidian.appdata.xml

md.obsidian.Obsidian.yml

barthalion · 2020-10-12T06:54:59Z

FYI you can trigger new builds yourself with bot, build md.obsidian.Obsidian.

…ta to build

joshua-stone · 2020-10-12T13:55:58Z

bot, build md.obsidian.Obsidian

flathubbot · 2020-10-12T15:01:42Z

Queued test build for md.obsidian.Obsidian.

flathubbot · 2020-10-12T15:01:55Z

Started test build 30192

flathubbot · 2020-10-12T15:03:56Z

Build 30192 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/29077/md.obsidian.Obsidian.flatpakref

joshua-stone · 2020-10-12T18:45:43Z

bot, build md.obsidian.Obsidian

flathubbot · 2020-10-12T18:45:44Z

Queued test build for md.obsidian.Obsidian.

flathubbot · 2020-10-12T18:45:58Z

Started test build 30205

flathubbot · 2020-10-12T18:48:01Z

Build 30205 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/29090/md.obsidian.Obsidian.flatpakref

barthalion · 2020-10-13T06:31:09Z

My only gripe is short description. When that's improved, it's ready to merge.

barthalion · 2020-10-13T06:31:38Z

@lishid, would you like to have write access to the Flathub repository, just in case?

lishid · 2020-10-13T07:16:26Z

@lishid, would you like to have write access to the Flathub repository, just in case?

Sure that would definitely help!

joshua-stone · 2020-10-13T19:01:01Z

bot, build md.obsidian.Obsidian

flathubbot · 2020-10-13T19:01:02Z

Queued test build for md.obsidian.Obsidian.

flathubbot · 2020-10-13T19:01:16Z

Started test build 30279

flathubbot · 2020-10-13T19:03:25Z

Build 30279 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/29164/md.obsidian.Obsidian.flatpakref

joshua-stone · 2020-10-13T20:15:37Z

bot, build md.obsidian.Obsidian

flathubbot · 2020-10-13T20:15:39Z

Queued test build for md.obsidian.Obsidian.

flathubbot · 2020-10-13T20:15:53Z

Started test build 30281

flathubbot · 2020-10-13T20:17:39Z

Build 30281 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/29167/md.obsidian.Obsidian.flatpakref

joshua-stone · 2020-10-13T20:27:38Z

bot, build md.obsidian.Obsidian

flathubbot · 2020-10-13T20:27:41Z

Queued test build for md.obsidian.Obsidian.

flathubbot · 2020-10-13T20:27:54Z

Started test build 30282

flathubbot · 2020-10-13T20:29:33Z

Build 30282 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/29168/md.obsidian.Obsidian.flatpakref

barthalion · 2020-10-14T08:37:02Z

md.obsidian.Obsidian.yml

+      - cp -r * ${FLATPAK_DEST}
+    sources:
+      - type: archive
+        url: https://github.com/obsidianmd/obsidian-releases/releases/download/v0.9.3/obsidian-0.9.3.tar.gz


One thing I'd add here is x-data-checker as documented at https://github.com/flathub/flatpak-external-data-checker so Flathub version doesn't fall behind with releases, but that can be fixed after merge.

barthalion · 2020-10-14T08:38:59Z

/merge @lishid

flathubbot · 2020-10-14T08:46:08Z

A repository for this has been created: https://github.com/flathub/md.obsidian.Obsidian

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

joshua-stone added 6 commits Oct 11, 2020

Add initial Obsidian manifest

777e130

Add proprietary tag

b7b40bf

Add .gitignore to ignore flatpak build artifacts

073f129

Add appdata file

e7a6ac6

Fix affiliation info

7e433c7

Fix formatting of sed substitutions

7cc578d

joshua-stone changed the title ~~Md.obsidian.obsidian~~ Add md.obsidian.obsidian (Obsidian) Oct 11, 2020

Update launcher to handle obsidian:// URI scheme

622c69a

joshua-stone added 2 commits Oct 11, 2020

Refactor build to use tar.gz instead of appimage

dbb2375

Add network access

bdc00b0

joshua-stone changed the title ~~Add md.obsidian.obsidian (Obsidian)~~ Add md.obsidian.Obsidian (Obsidian) Oct 11, 2020

joshua-stone added 5 commits Oct 11, 2020

More cleanups

b5a11d9

Fix alignment

490a2ea

Change up build process to set up files without needing to clean up

e8c1119

Add flathub metadata

1b5d943

Update description for clarifying on automatic updates

94626ba

barthalion reviewed Oct 12, 2020

View changes

Remove smaller icon sizes and let flatpak resize them, plus add appda…

a1a7e64

…ta to build

Update license reference

0e61bc6

Update appdata to include a more in-depth description

55accef

Add more to the description

db94c7b

Add translations URL

5f3df56

barthalion reviewed Oct 14, 2020

View changes

flathubbot closed this Oct 14, 2020

flathub / flathub Public

Add md.obsidian.Obsidian (Obsidian) #1883

Add md.obsidian.Obsidian (Obsidian) #1883

Conversation

joshua-stone commented Oct 11, 2020

nedrichards commented Oct 11, 2020

flathubbot commented Oct 11, 2020

flathubbot commented Oct 11, 2020

flathubbot commented Oct 11, 2020

joshua-stone commented Oct 11, 2020

barthalion commented Oct 12, 2020

flathubbot commented Oct 12, 2020

flathubbot commented Oct 12, 2020

flathubbot commented Oct 12, 2020

barthalion commented Oct 12, 2020

barthalion Oct 12, 2020

Choose a reason for hiding this comment

barthalion commented Oct 12, 2020

joshua-stone commented Oct 12, 2020

flathubbot commented Oct 12, 2020

flathubbot commented Oct 12, 2020

flathubbot commented Oct 12, 2020

joshua-stone commented Oct 12, 2020

flathubbot commented Oct 12, 2020

flathubbot commented Oct 12, 2020

flathubbot commented Oct 12, 2020

barthalion commented Oct 13, 2020

barthalion commented Oct 13, 2020

lishid commented Oct 13, 2020

joshua-stone commented Oct 13, 2020

flathubbot commented Oct 13, 2020

flathubbot commented Oct 13, 2020

flathubbot commented Oct 13, 2020

joshua-stone commented Oct 13, 2020

flathubbot commented Oct 13, 2020

flathubbot commented Oct 13, 2020

flathubbot commented Oct 13, 2020

joshua-stone commented Oct 13, 2020

flathubbot commented Oct 13, 2020

flathubbot commented Oct 13, 2020

flathubbot commented Oct 13, 2020

barthalion Oct 14, 2020

Choose a reason for hiding this comment

barthalion commented Oct 14, 2020

flathubbot commented Oct 14, 2020