Org.onionshare.onion share #2129

micahflee · 2021-02-22T02:16:38Z

Please confirm your submission meets all the criteria

I have read the App Requirements and App Maintenance pages.
My pull request follows the instructions at App Submission.
I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

kushaldas · 2021-02-22T03:43:53Z

It will be an amazing addition. Thank you @micahflee.

barthalion · 2021-02-22T07:42:28Z

README.md

@@ -1,27 +1,8 @@
-# Flathub


Feel free to delete this file too.

barthalion · 2021-02-22T07:42:28Z

org.onionshare.OnionShare.yaml

+  - "--share=ipc"
+  - "--share=network"
+  - "--socket=wayland"
+  - "--socket=x11"


Suggested change

- "--socket=x11"

- "--socket=fallback-x11"

barthalion · 2021-02-22T07:42:28Z

org.onionshare.OnionShare.yaml

+  - "--talk-name=org.freedesktop.secrets"
+  - "--filesystem=home:ro"
+  - "--filesystem=~/OnionShare:create"
+  - "--filesystem=xdg-config/onionshare:create"


Suggested change

- "--filesystem=xdg-config/onionshare:create"

Your application has write access to $XDG_CONFIG_HOME by default.

barthalion · 2021-02-22T07:42:28Z

org.onionshare.OnionShare.yaml

+  - "--share=network"
+  - "--socket=wayland"
+  - "--socket=x11"
+  - "--talk-name=org.freedesktop.Flatpak"


What do you need it for?

barthalion · 2021-02-22T07:42:28Z

org.onionshare.OnionShare.yaml

+          - mkdir -p /app/include/qt5tmp && cp -R /usr/include/Qt* /app/include/qt5tmp # https://bugreports.qt.io/browse/PYSIDE-787
+          - sed -i 's|\(--include-paths=\)|\1/app/include/qt5tmp:|' sources/pyside2/cmake/Macros/PySideModules.cmake
+  - name: tor
+    buildsystem: simple


Why not use autotools here?

barthalion · 2021-02-22T07:42:28Z

org.onionshare.OnionShare.yaml

+        url: https://dist.torproject.org/tor-0.4.5.6.tar.gz
+    modules:
+      - name: libevent
+        buildsystem: simple


Same as above.

barthalion · 2021-02-22T07:42:28Z

org.onionshare.OnionShare.yaml

+        GOBIN: "/app/bin/"
+        GO111MODULE: "off"
+    build-commands:
+      - ". /usr/lib/sdk/golang/enable.sh; GOPATH=$PWD go install gitlab.com/yawning/obfs4.git/obfs4proxy"


Does it actually work? Flathub runs builds offline, https://github.com/flatpak/flatpak-builder-tools/tree/master/go-get can be used to generate manifest automatically.

barthalion · 2021-02-22T07:42:28Z

org.onionshare.OnionShare.yaml

+      - type: dir
+        path: ../desktop/src
+    modules:
+      - name: python3-qrcode


There's a generator for pip too, if it makes the work simpler for you: https://github.com/flatpak/flatpak-builder-tools/tree/master/pip

barthalion · 2021-02-22T07:42:36Z

bot, build org.onionshare.OnionShare

flathubbot · 2021-02-22T07:42:37Z

Queued test build for org.onionshare.OnionShare.

flathubbot · 2021-02-22T07:42:50Z

Started test build 39943

flathubbot · 2021-02-22T07:44:06Z

Build 39943 failed

Erick555 · 2021-02-22T10:37:11Z

org.onionshare.OnionShare.yaml

+  - "--talk-name=org.freedesktop.Flatpak"
+  - "--talk-name=org.freedesktop.Notifications"
+  - "--talk-name=org.freedesktop.secrets"
+  - "--filesystem=home:ro"


Can this app use portals? If yes then you may not need this permission.

micahflee · 2021-02-23T01:32:08Z

bot, build org.onionshare.OnionShare

flathubbot · 2021-02-23T01:32:09Z

Queued test build for org.onionshare.OnionShare.

flathubbot · 2021-02-23T01:32:22Z

Started test build 39993

flathubbot · 2021-02-23T01:56:41Z

Build 39993 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/38489/org.onionshare.OnionShare.flatpakref

…ot needed

micahflee · 2021-02-23T03:47:25Z

Okay, I've fixed the manifest and addressed all of your comments, and it seems ready to go.

Your application has write access to $XDG_CONFIG_HOME by default.

Without this in finish-args:

   - "--filesystem=xdg-config/onionshare:create"

I get this error:

$ flatpak run org.onionshare.OnionShare
OnionShare 2.3.1 | https://onionshare.org/
Gtk-Message: 19:29:10.970: Failed to load module "canberra-gtk-module"
Gtk-Message: 19:29:10.971: Failed to load module "canberra-gtk-module"
Qt: Session management error: None of the authentication protocols specified are supported
Traceback (most recent call last):
  File "/app/bin/onionshare", line 33, in <module>
  File "/app/lib/python3.8/site-packages/onionshare-2.3.1-py3.8.egg/onionshare/__init__.py", line 177, in main
OSError: [Errno 30] Read-only file system: '/home/user/.config/onionshare/lock'

The problem is in upstream OnionShare is writing directly to ~/.config/onionshare instead of to $XDG_CONFIG_HOME . So I'm keeping it for now, but I opened in issue upstream: onionshare/onionshare#1293

I made the tor and libevent modules use autotools.

I actually did use the flatpak-builder-tools repo for both pip dependencies and for the golang obfs4proxy module, though it turns out https://github.com/flatpak/flatpak-builder-tools/tree/master/go-get doesn't work anymore as of about 6 days ago when https://github.com/flathub/org.freedesktop.Sdk.Extension.golang updated golang to 1.16 -- it took awhile to realize I needed the GO111MODULE=off environment variable for this older way of getting go sources to work.

micahflee · 2021-02-23T03:47:34Z

bot, build org.onionshare.OnionShare

flathubbot · 2021-02-23T03:47:35Z

Queued test build for org.onionshare.OnionShare.

flathubbot · 2021-02-23T03:47:49Z

Started test build 39998

micahflee · 2021-02-23T03:50:12Z

Oh yeah and

Can this app use portals? If yes then you may not need this permission.

I'd like to use portals, but it's not yet implemented.

flathubbot · 2021-02-23T04:19:31Z

Build 39998 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/38494/org.onionshare.OnionShare.flatpakref

barthalion · 2021-02-23T12:38:47Z

/merge

flathubbot · 2021-02-23T12:39:23Z

A repository for this has been created: https://github.com/flathub/org.onionshare.OnionShare

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

micahflee added 2 commits February 21, 2021 18:06

Added OnionShare manifest

b52de6a

Initial commit for OnionShare

0e68776

barthalion reviewed Feb 22, 2021

View reviewed changes

Erick555 reviewed Feb 22, 2021

View reviewed changes

Delete readme

c8bb99a

micahflee mentioned this pull request Feb 23, 2021

Flatpak App Not Found onionshare/onionshare#1290

Closed

Pull source from OnionShare's git repo instead of directories

d2adc47

micahflee added 2 commits February 22, 2021 19:37

Remove --talk-name=org.freedesktop.Flatpak permission because it is n…

6838cbb

…ot needed

Just use GO111MODULE=off in the build command

aca4e70

flathubbot closed this Feb 23, 2021

Org.onionshare.onion share #2129

Org.onionshare.onion share #2129

micahflee commented Feb 22, 2021

kushaldas commented Feb 22, 2021

barthalion Feb 22, 2021

barthalion Feb 22, 2021

barthalion Feb 22, 2021

barthalion Feb 22, 2021

barthalion Feb 22, 2021

barthalion Feb 22, 2021

barthalion Feb 22, 2021

barthalion Feb 22, 2021

barthalion commented Feb 22, 2021

flathubbot commented Feb 22, 2021

flathubbot commented Feb 22, 2021

flathubbot commented Feb 22, 2021

Erick555 Feb 22, 2021

micahflee commented Feb 23, 2021

flathubbot commented Feb 23, 2021

flathubbot commented Feb 23, 2021

flathubbot commented Feb 23, 2021

micahflee commented Feb 23, 2021

micahflee commented Feb 23, 2021

flathubbot commented Feb 23, 2021

flathubbot commented Feb 23, 2021

micahflee commented Feb 23, 2021

flathubbot commented Feb 23, 2021

barthalion commented Feb 23, 2021

flathubbot commented Feb 23, 2021

Org.onionshare.onion share #2129

Org.onionshare.onion share #2129

Conversation

micahflee commented Feb 22, 2021

Please confirm your submission meets all the criteria

kushaldas commented Feb 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

barthalion commented Feb 22, 2021

flathubbot commented Feb 22, 2021

flathubbot commented Feb 22, 2021

flathubbot commented Feb 22, 2021

Choose a reason for hiding this comment

micahflee commented Feb 23, 2021

flathubbot commented Feb 23, 2021

flathubbot commented Feb 23, 2021

flathubbot commented Feb 23, 2021

micahflee commented Feb 23, 2021

micahflee commented Feb 23, 2021

flathubbot commented Feb 23, 2021

flathubbot commented Feb 23, 2021

micahflee commented Feb 23, 2021

flathubbot commented Feb 23, 2021

barthalion commented Feb 23, 2021

flathubbot commented Feb 23, 2021