add org.qelectrotech.QElectroTech by kevinsmia1939 · Pull Request #2146 · flathub/flathub

kevinsmia1939 · 2021-03-03T17:07:04Z

Please confirm your submission meets all the criteria

I have read the App Requirements and App Maintenance pages.
My pull request follows the instructions at App Submission.
I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Can we submit Flatpak to Flathub? qelectrotech/qelectrotech-source-mirror#143
I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

bilelmoussaoui · 2021-03-03T17:19:18Z

+          "type": "dir",
+          "path": "../.."


You need a tarball/git source here

https://git.tuxfamily.org/qet/qet.git/tag/?id=0.8.0

Or
https://github.com/qelectrotech/qelectrotech-source-mirror/releases/tag/0.8.0

bilelmoussaoui · 2021-03-03T17:19:30Z

+{
+  "id": "org.qelectrotech.QElectroTech",
+  "runtime": "org.kde.Platform",
+  "runtime-version": "5.14",


Maybe bump it to 5.15?

Build fine with runtime-version": "5.15" here see:
https://qelectrotech.org/forum/viewtopic.php?pid=14448#p14448

nedrichards · 2021-03-03T20:47:24Z

bot, build org.qelectrotech.QElectroTech

flathubbot · 2021-03-03T20:47:25Z

Queued test build for org.qelectrotech.QElectroTech.

flathubbot · 2021-03-03T20:47:38Z

Started test build 40746

scorpio810 · 2021-03-03T21:01:24Z

$ flatpak install flathub org.kde.Platform//5.15 org.kde.Sdk//5.15
$ flatpak-builder --force-clean --ccache --user --install _build build-aux/flatpak/org.qelectrotech.QElectroTech.json

My script to build flatpak to my repository
https://qelectrotech.org/wiki_new/doc/packaging_debian#flatpak

flathubbot · 2021-03-03T22:07:37Z

Build 40746 failed

barthalion · 2021-03-04T08:09:40Z

bot, build org.qelectrotech.QElectroTech

flathubbot · 2021-03-04T08:09:41Z

Queued test build for org.qelectrotech.QElectroTech.

flathubbot · 2021-03-04T08:10:00Z

Started test build 40782

barthalion · 2021-03-04T08:41:04Z

Failed to notice there are some fixes pending to make it actually buildable.

flathubbot · 2021-03-04T08:41:46Z

Build 40782 was cancelled

tinywrkb · 2021-03-04T18:38:35Z

+    "--socket=x11",
+    "--device=dri",
+    "--share=ipc",
+    "--filesystem=host"


The --filesystem=host is a little too permissive for this kind of app.
A User who blocks this permission will hit an issue with the app home folder not being kept so maybe add a comment somewhere about ~/.qet? or maybe just add - --persist=.qet?

Need input from @scorpio810 on this.

Yes, what do you need full host permissions for? As @tinywrkb says we should allow the absolute minimum surface that lets the app access its configuration (ideally that uses xdg-config dirs so it doesn't need a permission at all, but a --persist=.qet could work too - and then as a modern Qt app I'd hope that it should be able to use the file portal to open and save files anywhere on the system as required without extra permissions.

You can test this yourself locally with --nofilesystem=host and the persist flag mentioned above on the flatpak CLI - or use an app like flatseal https://flathub.org/apps/details/com.github.tchx84.Flatseal to experiment with the permissions and minimise them.

Certainly host permissions require explicit justification that is core to the purpose of the app.

I think qelectrotech doesn't use portals. It's not possible to save a project if you take away the host permission.

kevinsmia1939 · 2021-03-24T17:58:41Z

i mess up some thing

kevinsmia1939 · 2021-03-24T18:31:54Z

bot, build org.qelectrotech.QElectroTech

flathubbot · 2021-03-24T18:31:55Z

Queued test build for org.qelectrotech.QElectroTech.

flathubbot · 2021-03-24T18:32:09Z

Started test build 42633

flathubbot · 2021-03-24T19:55:20Z

Build 42633 failed

kevinsmia1939 · 2021-03-27T15:11:18Z

I don't understand why the patch failed, it build just fine locally on my machine.

kevinsmia1939 · 2021-03-27T17:16:43Z

bot, build org.qelectrotech.QElectroTech

flathubbot · 2021-03-27T17:16:44Z

Queued test build for org.qelectrotech.QElectroTech.

flathubbot · 2021-03-27T17:22:09Z

Started test build 42999

kevinsmia1939 · 2021-05-03T21:58:30Z

bot, build org.qelectrotech.QElectroTech

flathubbot · 2021-05-03T21:58:31Z

Queued test build for org.qelectrotech.QElectroTech.

flathubbot · 2021-05-03T21:58:45Z

Started test build 46973

flathubbot · 2021-05-03T22:07:53Z

Build 46973 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/45176/org.qelectrotech.QElectroTech.flatpakref

scorpio810 · 2021-05-20T07:41:44Z

@kevinsmia1939 Raul provide new version of qet_tb_generator 1.2.5 plugin, but this version need PySimpleGUI depend.
Is possible for you to add this?
https://pypi.org/project/qet-tb-generator/#copy-hash-modal-cbf95192-6fb4-48f0-aa6f-9e4441c95565

See :
https://qelectrotech.org/forum/viewtopic.php?pid=14954#p14954

kevinsmia1939 · 2021-05-20T10:31:59Z

@scorpio810
This one? https://pypi.org/project/PySimpleGUI/

kevinsmia1939 · 2021-05-20T11:20:27Z

bot, build org.qelectrotech.QElectroTech

flathubbot · 2021-05-20T11:20:28Z

Queued test build for org.qelectrotech.QElectroTech.

scorpio810 · 2021-05-20T12:09:13Z

@scorpio810
This one? https://pypi.org/project/PySimpleGUI/

Yes.

flathubbot · 2021-05-20T12:30:13Z

Started test build 48709

flathubbot · 2021-05-20T12:40:12Z

Build 48709 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/46848/org.qelectrotech.QElectroTech.flatpakref

scorpio810 · 2021-05-20T14:53:40Z

Tried 79b092b on 0.9-dev, work great.
Thanks kevinsmia1939.

kevinsmia1939 · 2021-05-20T16:05:06Z

Ok, I think it is ready now.

This reverts commit 7966d43.

barthalion · 2021-05-25T05:55:48Z

/merge @scorpio810

barthalion · 2021-05-25T06:19:19Z

bot, build org.qelectrotech.QElectroTech

flathubbot · 2021-05-25T06:19:20Z

Queued test build for org.qelectrotech.QElectroTech.

flathubbot · 2021-05-25T06:19:37Z

Started test build 49091

flathubbot · 2021-05-25T06:28:54Z

Build 49091 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/47225/org.qelectrotech.QElectroTech.flatpakref

barthalion · 2021-05-25T06:33:17Z

/merge @scorpio810

flathubbot · 2021-05-25T06:33:55Z

A repository for this has been created: https://github.com/flathub/org.qelectrotech.QElectroTech

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

scorpio810 · 2022-01-06T11:22:49Z

bot, build org.qelectrotech.QElectroTech

flathubbot · 2022-01-06T11:22:50Z

Queued test build for org.qelectrotech.QElectroTech.

flathubbot · 2022-01-06T11:23:05Z

Started test build 73601

flathubbot · 2022-01-06T12:37:53Z

Build 73601 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/71452/org.qelectrotech.QElectroTech.flatpakref

add QeT manifiest

b3e5b46

kevinsmia1939 mentioned this pull request Mar 3, 2021

Can we submit Flatpak to Flathub? qelectrotech/qelectrotech-source-mirror#143

Closed

bilelmoussaoui reviewed Mar 3, 2021

View reviewed changes

nedrichards changed the title ~~New Submission QElectroTech~~ add org.qelectrotech.QElectroTech Mar 3, 2021

tinywrkb reviewed Mar 4, 2021

View reviewed changes

Comment thread org.qelectrotech.QElectroTech.json Outdated

add yaml descriptions

82692c6

recommit

934a607

fall back x11

f5a1b62

move patch file

f8198b5

update qet tb gen

79b092b

Kavin Teenakul added 2 commits May 20, 2021 23:19

prepare for noisetorch

7966d43

Revert "prepare for noisetorch"

531ed93

This reverts commit 7966d43.

Drop .gitmodules

3f1796c

flathubbot closed this May 25, 2021

kevinsmia1939 deleted the new-pr branch May 25, 2021 15:21

Conversation

kevinsmia1939 commented Mar 3, 2021

Please confirm your submission meets all the criteria

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nedrichards commented Mar 3, 2021

Uh oh!

flathubbot commented Mar 3, 2021

Uh oh!

flathubbot commented Mar 3, 2021

Uh oh!

scorpio810 commented Mar 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flathubbot commented Mar 3, 2021

Uh oh!

barthalion commented Mar 4, 2021

Uh oh!

flathubbot commented Mar 4, 2021

Uh oh!

flathubbot commented Mar 4, 2021

Uh oh!

barthalion commented Mar 4, 2021

Uh oh!

flathubbot commented Mar 4, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kevinsmia1939 commented Mar 24, 2021

Uh oh!

kevinsmia1939 commented Mar 24, 2021

Uh oh!

flathubbot commented Mar 24, 2021

Uh oh!

flathubbot commented Mar 24, 2021

Uh oh!

flathubbot commented Mar 24, 2021

Uh oh!

kevinsmia1939 commented Mar 27, 2021

Uh oh!

kevinsmia1939 commented Mar 27, 2021

Uh oh!

flathubbot commented Mar 27, 2021

Uh oh!

flathubbot commented Mar 27, 2021

Uh oh!

kevinsmia1939 commented May 3, 2021

Uh oh!

flathubbot commented May 3, 2021

Uh oh!

flathubbot commented May 3, 2021

Uh oh!

flathubbot commented May 3, 2021

Uh oh!

scorpio810 commented May 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevinsmia1939 commented May 20, 2021

Uh oh!

kevinsmia1939 commented May 20, 2021

Uh oh!

flathubbot commented May 20, 2021

scorpio810 commented Mar 3, 2021 •

edited

Loading

scorpio810 commented May 20, 2021 •

edited

Loading