Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Otter Browser #288

Closed
wants to merge 13 commits into from
Closed

Add Otter Browser #288

wants to merge 13 commits into from

Conversation

jurf
Copy link
Member

@jurf jurf commented Mar 2, 2018

Otter Browser aims to recreate the best aspects of the classic Opera (12.x) UI using Qt5.

Easily the easiest Flatpak I’ve ever created. Kudos, @Emdek!

@jurf
Copy link
Member Author

jurf commented Mar 2, 2018

bot, build org.otter_browser.OtterBrowser

Copy link
Member

@barthalion barthalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plans on @Emdek involvement (or anyone else from the project), or has it never been discussed before?

"modules": [
{
"name": "otter-browser",
"buildsystem": "cmake",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake-ninja

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t that experimental?

"rename-appdata-file": "otter-browser.appdata.xml",
"rename-icon": "otter-browser",
"finish-args": [
"--device=dri",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No xdg-download?

Copy link
Member Author

@jurf jurf Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t help, still downloads things to /tmp. If downloading via ’Save as…’ then it produces an invalid file. Isn’t there a way to disable portals altogether? Maybe by unsetting the Qt platform variable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t there a way to disable portals altogether?

That is moving in the wrong direction, portals should be used or fixed if there are problems. Disabling them would just be a bad workaround.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or it should be patched to properly download files where they belong;

org.otter_browser.OtterBrowser.json Outdated Show resolved Hide resolved
@jurf
Copy link
Member Author

jurf commented Mar 2, 2018

No, it hasn’t been discussed before, I just went and done it :P

"--socket=x11",
"--socket=pulseaudio",
"--filesystem=xdg-download",
"--env=QTWEBENGINE_DISABLE_SANDBOX=1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does it use webengine or webkit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do both, you can choose, but WebEngine is more experimental.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling sandboxing sounds worse than not having qtwebengine enabled at all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it doesn’t run in Flatpak and we have Bubblewrap anyway, I don’t see a problem with this, I took this from existing Flathub manifests.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barthalion Revived QtWebKit is quite capable. No QtWebEngine isn't bad at all really. ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno, keep sandbox disabled or disable WebEngine?

@jurf
Copy link
Member Author

jurf commented Mar 2, 2018

bot, build org.otter_browser.OtterBrowser

@TingPing
Copy link
Member

TingPing commented Mar 14, 2018

This was discussed briefly on IRC and since Otter does not yet have a stable release we will wait to add this to Flathub. I also hope by time it hits "stable" that QtWebEngine support will be considered stable also.

@jurf
Copy link
Member Author

jurf commented Jan 2, 2019

Stable now available: https://thedndsanctuary.eu/index.php?topic=3574.0

However, QtWebEngine is still considered experimental.

@jurf
Copy link
Member Author

jurf commented Apr 1, 2019

bot, build org.otter_browser.OtterBrowser

@flathubbot
Copy link

Queued test build for org.otter_browser.OtterBrowser.

@flathubbot
Copy link

Started test build 1895

@flathubbot
Copy link

Build 1895 failed

@LeandroStanger
Copy link

bot, build org.otter_browser.OtterBrowser

@flathubbot
Copy link

Queued test build for org.otter_browser.OtterBrowser.

@flathubbot
Copy link

Started test build 6825

@flathubbot
Copy link

Build 6825 failed

@flathubbot
Copy link

This PR hasn't received any updates in a year and will be automatically closed in 14 days. Feel free to re-open it if you plan to continue working on that pull request or think it deserves attention from Flathub admins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants