-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add com.github.aldrinzigmundv.MoonLight #2912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build will fail
| "--socket=fallback-x11", | ||
| "--socket=wayland", | ||
| "--device=dri", | ||
| "--env=RUST_LOG=moonlight=debug", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you really need debug logging for release?
| "finish-args" : [ | ||
| "--socket=fallback-x11", | ||
| "--socket=wayland", | ||
| "--device=dri", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "--device=dri", | |
| "--device=dri", | |
| "--share=ipc", |
IPC is still needed
| "build-options" : { | ||
| "append-path" : "/usr/lib/sdk/rust-stable/bin", | ||
| "build-args" : [ | ||
| "--share=network" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will fail there is no network.
Two options:
- use flatpak-builder-tools to generate the cargo dependencies
- use the tarball as the meson template will vendor the cargo crates.
I recommend option 2 it available.
| "build-args" : [ | ||
| "--share=network" | ||
| ], | ||
| "test-args": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neither will this work.
|
Wrong manifest file uploaded. |
|
no need to close to fix this. just push again to the branch. that's how it works. |
Please confirm your submission meets all the criteria