Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.github.aldrinzigmundv.MoonLight #2912

Closed
wants to merge 1 commit into from
Closed

Add com.github.aldrinzigmundv.MoonLight #2912

wants to merge 1 commit into from

Conversation

aldrinzigmundv
Copy link

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

Copy link
Contributor

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build will fail

"--socket=fallback-x11",
"--socket=wayland",
"--device=dri",
"--env=RUST_LOG=moonlight=debug",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need debug logging for release?

"finish-args" : [
"--socket=fallback-x11",
"--socket=wayland",
"--device=dri",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"--device=dri",
"--device=dri",
"--share=ipc",

IPC is still needed

"build-options" : {
"append-path" : "/usr/lib/sdk/rust-stable/bin",
"build-args" : [
"--share=network"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fail there is no network.

Two options:

  1. use flatpak-builder-tools to generate the cargo dependencies
  2. use the tarball as the meson template will vendor the cargo crates.

I recommend option 2 it available.

"build-args" : [
"--share=network"
],
"test-args": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither will this work.

@aldrinzigmundv
Copy link
Author

Wrong manifest file uploaded.

@aldrinzigmundv aldrinzigmundv deleted the moonlight branch March 18, 2022 15:46
@hfiguiere
Copy link
Contributor

no need to close to fix this. just push again to the branch. that's how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants