New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeoGebra #42

Closed
wants to merge 5 commits into
from

Conversation

3 participants
@manuq

manuq commented Jun 22, 2017

Using the GeoGebra Linux portable version, which works for
x86_64 and i386 architectures.

The desktop file and icon were grabbed from the RPM.

GeoGebra license is non-commercial. See https://www.geogebra.org/license
for details.

Add GeoGebra
Using the GeoGebra Linux portable version, which works for
x86_64 and i386 architectures.

The desktop file and icon were grabbed from the RPM.

GeoGebra license is non-commercial. See https://www.geogebra.org/license
for details.
Show outdated Hide outdated org.geogebra.GeoGebra.json
"sources": [
{
"type": "archive",
"url": "https://download.geogebra.org/installers/5.0/GeoGebra-Linux-Portable-5-0-367-0.tar.bz2",

This comment has been minimized.

@TingPing

TingPing Jun 22, 2017

Member

Looks like this bundles the entire JRE for both 32 and 64bit. At the very least this should only install the one used.

@TingPing

TingPing Jun 22, 2017

Member

Looks like this bundles the entire JRE for both 32 and 64bit. At the very least this should only install the one used.

This comment has been minimized.

@manuq

manuq Jun 22, 2017

@TingPing I have pushed a new commit that should solve this and the other things marked in your review.
I couldn't find tarballs to download the specific versions of the JRE, so I added a script to remove the unwanted one with a only-arches.

@manuq

manuq Jun 22, 2017

@TingPing I have pushed a new commit that should solve this and the other things marked in your review.
I couldn't find tarballs to download the specific versions of the JRE, so I added a script to remove the unwanted one with a only-arches.

@TingPing

This comment has been minimized.

Show comment
Hide comment
@TingPing

TingPing Jun 22, 2017

Member

Missing an appdata file.

Also need to make a flathub.json file to skip unsupported arches. (See example)

Member

TingPing commented Jun 22, 2017

Missing an appdata file.

Also need to make a flathub.json file to skip unsupported arches. (See example)

@manuq

This comment has been minimized.

Show comment
Hide comment
@manuq

manuq Jun 22, 2017

Thanks @TingPing, will the flathub.json file be automatically catched? I don't see it imported in the example by the main com.spotify.Client.json manifest.

manuq commented Jun 22, 2017

Thanks @TingPing, will the flathub.json file be automatically catched? I don't see it imported in the example by the main com.spotify.Client.json manifest.

@TingPing

This comment has been minimized.

Show comment
Hide comment
@TingPing

TingPing Jun 22, 2017

Member

Yes it is picked up by the flathub builders.

Member

TingPing commented Jun 22, 2017

Yes it is picked up by the flathub builders.

Fixups
Add appdata.xml, skip building ARM, install only the JRE corresponding
for the building arch.
<developer_name>GeoGebra</developer_name>
<summary>Dynamic mathematics software</summary>
<metadata_license>CC0-1.0</metadata_license>
<project_license>LicenseRef-proprietary</project_license>

This comment has been minimized.

@TingPing

TingPing Jun 22, 2017

Member

Ah didn't realize this was proprietary. Does upstream have a license that allows redistribution? If not you have to configure this to download at runtime like the Spotify flatpak.

@TingPing

TingPing Jun 22, 2017

Member

Ah didn't realize this was proprietary. Does upstream have a license that allows redistribution? If not you have to configure this to download at runtime like the Spotify flatpak.

This comment has been minimized.

@manuq

manuq Jun 22, 2017

Yeah as I added in the commit message: GeoGebra license is non-commercial. See https://www.geogebra.org/license for details.

In the freedesktop.org site I couldn't find an option for <project_license> that matches. The site refers to https://spdx.org/licenses/ but those are all open licenses.

@manuq

manuq Jun 22, 2017

Yeah as I added in the commit message: GeoGebra license is non-commercial. See https://www.geogebra.org/license for details.

In the freedesktop.org site I couldn't find an option for <project_license> that matches. The site refers to https://spdx.org/licenses/ but those are all open licenses.

This comment has been minimized.

@manuq

manuq Jun 22, 2017

Reading more in their license page...

  • "You are free to copy, distribute and transmit GeoGebra for non-commercial purposes".
  • The source code is "GPL v3 or later" and can be found here https://github.com/geogebra/geogebra
  • The language files for translations and artwork like the icon I added here are: Creative Commons Attribution-NonCommercial-ShareAlike license (version 3.0 or later)
@manuq

manuq Jun 22, 2017

Reading more in their license page...

  • "You are free to copy, distribute and transmit GeoGebra for non-commercial purposes".
  • The source code is "GPL v3 or later" and can be found here https://github.com/geogebra/geogebra
  • The language files for translations and artwork like the icon I added here are: Creative Commons Attribution-NonCommercial-ShareAlike license (version 3.0 or later)

This comment has been minimized.

@TingPing

TingPing Jun 22, 2017

Member

So if the code is GPL3+, which part are they distributing that is non-free? Assets?

@TingPing

TingPing Jun 22, 2017

Member

So if the code is GPL3+, which part are they distributing that is non-free? Assets?

This comment has been minimized.

@manuq

manuq Jun 22, 2017

I'm also confused. They seem to put a non-commercial clause on top ofr GPL which allows commercial use...

@manuq

manuq Jun 22, 2017

I'm also confused. They seem to put a non-commercial clause on top ofr GPL which allows commercial use...

This comment has been minimized.

@barthalion

barthalion Jun 22, 2017

Member

In past they wanted Arch to drop the package that repackaged this tarball from repositories for some silly reasons. I'm not sure if we want to handle this here as well.

@barthalion

barthalion Jun 22, 2017

Member

In past they wanted Arch to drop the package that repackaged this tarball from repositories for some silly reasons. I'm not sure if we want to handle this here as well.

This comment has been minimized.

@manuq

manuq Jun 22, 2017

Ah didn't know. I thought it was fine to have a flatpak when I saw rpm, deb, and other installers available. OK you can close this PR then.

@manuq

manuq Jun 22, 2017

Ah didn't know. I thought it was fine to have a flatpak when I saw rpm, deb, and other installers available. OK you can close this PR then.

This comment has been minimized.

@barthalion

barthalion Jun 22, 2017

Member

I guess it will be technically fine if you change it to utilize extra-data though. (And nobody in Arch never got contacted again about it so YMMV.)

@barthalion

barthalion Jun 22, 2017

Member

I guess it will be technically fine if you change it to utilize extra-data though. (And nobody in Arch never got contacted again about it so YMMV.)

@manuq

This comment has been minimized.

Show comment
Hide comment
@manuq

manuq Jun 22, 2017

This last commit would do it. But I wasn't able to test it locally. flatpak-builder ends fine but when I try to install in a local repo I get a libostree crash:

[manuq@localhost flathub]$ flatpak --user install manuq-repo org.geogebra.GeoGebra
Updating: org.freedesktop.Platform/x86_64/1.6 from gnome
No updates.
Updating: org.freedesktop.Platform.Locale/x86_64/1.6 from gnome
No updates.
Installing: org.geogebra.GeoGebra/x86_64/master from manuq-repo

**
OSTree:ERROR:src/libostree/ostree-async-progress.c:214:ostree_async_progress_get: assertion failed: (variant != NULL)
Aborted (`core' generado)

manuq commented Jun 22, 2017

This last commit would do it. But I wasn't able to test it locally. flatpak-builder ends fine but when I try to install in a local repo I get a libostree crash:

[manuq@localhost flathub]$ flatpak --user install manuq-repo org.geogebra.GeoGebra
Updating: org.freedesktop.Platform/x86_64/1.6 from gnome
No updates.
Updating: org.freedesktop.Platform.Locale/x86_64/1.6 from gnome
No updates.
Installing: org.geogebra.GeoGebra/x86_64/master from manuq-repo

**
OSTree:ERROR:src/libostree/ostree-async-progress.c:214:ostree_async_progress_get: assertion failed: (variant != NULL)
Aborted (`core' generado)
@TingPing

This comment has been minimized.

Show comment
Hide comment
@TingPing

TingPing Jun 23, 2017

Member

@manuq If on latest releases of Flatpak/OSTree should open an issue over it.

Member

TingPing commented Jun 23, 2017

@manuq If on latest releases of Flatpak/OSTree should open an issue over it.

@manuq

This comment has been minimized.

Show comment
Hide comment
@manuq

manuq Jun 23, 2017

@TingPing I just upgraded to flatpak-0.9.5-1.fc25 in my Fedora and is being installed now.

manuq commented Jun 23, 2017

@TingPing I just upgraded to flatpak-0.9.5-1.fc25 in my Fedora and is being installed now.

@manuq

This comment has been minimized.

Show comment
Hide comment
@manuq

manuq Jun 23, 2017

Getting "error: Wrong size for extra data", please hold the review until I fix this.

manuq commented Jun 23, 2017

Getting "error: Wrong size for extra data", please hold the review until I fix this.

@TingPing

This comment has been minimized.

Show comment
Hide comment
@manuq

This comment has been minimized.

Show comment
Hide comment
@manuq

manuq Jun 23, 2017

Builds fine but the install fails with:

rm: cannot remove '/app/bin/cleanup-other-arches.sh': Read-only file system

error: While trying to apply extra data: apply_extra script failed, exit status 256

Pushed another commit to fix it.

manuq commented Jun 23, 2017

Builds fine but the install fails with:

rm: cannot remove '/app/bin/cleanup-other-arches.sh': Read-only file system

error: While trying to apply extra data: apply_extra script failed, exit status 256

Pushed another commit to fix it.

@manuq

This comment has been minimized.

Show comment
Hide comment
@manuq

manuq Jun 23, 2017

@TingPing GeoGebra installs fine now, and runs too. I tested locally.

manuq commented Jun 23, 2017

@TingPing GeoGebra installs fine now, and runs too. I tested locally.

@TingPing

This comment has been minimized.

Show comment
Hide comment
Member

TingPing commented Jun 27, 2017

@TingPing TingPing closed this Jun 27, 2017

@manuq

This comment has been minimized.

Show comment
Hide comment

manuq commented Jun 27, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment