New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Teo TO8D emulator #443

Closed
wants to merge 1 commit into
base: new-pr
from

Conversation

5 participants
@hadess

hadess commented Jun 21, 2018

The screenshots might be a bit small...

"sources" : [
{
"type" : "git",
"url" : "hg::http://hg.code.sf.net/p/teoemulator/code"

This comment has been minimized.

@nedrichards

nedrichards Jun 21, 2018

Member

this needs to be a reproducible source. so a git tag+commit or a release archive to be available on flathub.

@hadess

This comment has been minimized.

hadess commented Jun 22, 2018

Done, the git commit IDs look stable even after being munged through git-hg.

I plan on replacing the screenshots once this Flatpak has its own module.

AppStream doesn't have any correct option for the translation method used for this software (which also runs under DOS and Windows), where the language shown is either French (when in a French locale), or English for anything else.

@nedrichards

This comment has been minimized.

Member

nedrichards commented Jun 22, 2018

Ah, interesting.

@nedrichards

This comment has been minimized.

Member

nedrichards commented Jun 22, 2018

bot, build net.sourceforge.Teo

@nedrichards

This comment has been minimized.

Member

nedrichards commented Jun 22, 2018

The build failed: https://flathub.org/builds/#/builders/2/builds/2417
Looks like the cool workaround didn't work.

@hadess

This comment has been minimized.

hadess commented Jun 22, 2018

Of course, because flatpak-builder in this configuration will download everything first, then do the sequential build steps, and not download, build, download, build, etc.

I'll have to try and find a work-around for this, maybe a git mirror, or adding hg support to flatpak-builder (but then it'd need to be in the SDK somehow). If anyone has ideas...

@Alexander-Wilms

This comment has been minimized.

Alexander-Wilms commented Jun 23, 2018

Is there any reason not to add an archive of the commit to the PR?

@barthalion

This comment has been minimized.

Member

barthalion commented Jun 26, 2018

It needlessly increases the size of git repo with no way out in the future (as we disallow forcing pushes).

@hadess

This comment has been minimized.

hadess commented Jun 26, 2018

Note that this won't work without this patch to flatpak-builder:
flatpak/flatpak-builder#174

And that I still get warnings:

WARNING: Failed to validate desktop file /home/hadess/Projects/jhbuild/flathub/_build/export/share/applications/net.sourceforge.Teo.desktop: /home/hadess/Projects/jhbuild/flathub/_build/export/share/applications/net.sourceforge.Teo.desktop: error: file contains group "Reset Shortcut Group", but groups extending the format should start with "X-"

Unity extensions. Should those be warnings?

WARNING: Icon referenced in desktop file but not exported: net.sourceforge.Teo

The only icon file lives in /app/share/pixmaps. Is that not sufficient? (anymore?)

@Alexander-Wilms

This comment has been minimized.

Alexander-Wilms commented Jun 26, 2018

AFAIK, icons should live in /app/share/icons/hicolor/{64x64,scalable,etc}/apps.

@nedrichards

This comment has been minimized.

Member

nedrichards commented Jun 26, 2018

Yeah, pixmaps isn't sufficient anymore.

@hadess

This comment has been minimized.

hadess commented Jun 26, 2018

Why is that now a requirement? Flatpak used to export those files just fine. And when the application has a single icon...

@Alexander-Wilms

This comment has been minimized.

Alexander-Wilms commented Jun 26, 2018

https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html mentions that PREFIX/share/icons is preferred and only mentions /usr/share/pixmaps, (not even PREFIX/share/pixmaps) as fallback.

@hadess

This comment has been minimized.

hadess commented Jun 26, 2018

Was removed in:
flatpak/flatpak@d8ac76d

I can used /apps/pixmaps/icons instead. I'll do that once I've worked on the flatpak-builder patch some more.

Edit: I can use /app/share/icons. I'd blame being distracted for those typos.

@nedrichards

This comment has been minimized.

Member

nedrichards commented Jun 28, 2018

bot, build net.sourceforge.Teo

@hadess

This comment has been minimized.

hadess commented Jul 3, 2018

Failed with:

*** Please tell me who you are.
Run
  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <buildbot@cncf-arm-1.flathub.org>) not allowed

There's a bug in the git-init patch I made for flatpak-builder. Or we could add info for git-commit to work in Flathub, not sure.

@hadess

This comment has been minimized.

hadess commented Jul 13, 2018

I've worked around the git-init problem in this last version, hopefully, by using REAL_NAME and EMAIL_ADDRESS envvars.

@nedrichards

This comment has been minimized.

Member

nedrichards commented Jul 13, 2018

bot, build net.sourceforge.Teo

@nedrichards

This comment has been minimized.

Member

nedrichards commented Jul 13, 2018

@hadess

This comment has been minimized.

hadess commented Jul 13, 2018

boooooooo https://flathub.org/builds/#/builders/2/builds/2833

Yep, the build-options aren't used when preparing the sources :/

I've updated the flatpak-builder patch and fully tested it now, so we'll just have to wait for it before merging this. If someone has other ideas to work-around the problem...

@nedrichards

This comment has been minimized.

Member

nedrichards commented Jul 13, 2018

Sounds like we might have to wait until 1.0.1 then (plus rollout time).

@hadess

This comment has been minimized.

hadess commented Aug 11, 2018

Sounds like we might have to wait until 1.0.1 then (plus rollout time).

It's now merged, just need to wait for a release and roll-out.

@ramcq

This comment has been minimized.

ramcq commented Aug 21, 2018

bot, build net.sourceforge.Teo

@nedrichards

This comment has been minimized.

Member

nedrichards commented Aug 21, 2018

Repository has been created: https://github.com/flathub/net.sourceforge.Teo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment