New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Teo TO8D emulator #443
Conversation
net.sourceforge.Teo.json
Outdated
| "sources" : [ | ||
| { | ||
| "type" : "git", | ||
| "url" : "hg::http://hg.code.sf.net/p/teoemulator/code" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be a reproducible source. so a git tag+commit or a release archive to be available on flathub.
|
Done, the git commit IDs look stable even after being munged through git-hg. I plan on replacing the screenshots once this Flatpak has its own module. AppStream doesn't have any correct option for the translation method used for this software (which also runs under DOS and Windows), where the language shown is either French (when in a French locale), or English for anything else. |
|
Ah, interesting. |
|
bot, build net.sourceforge.Teo |
|
The build failed: https://flathub.org/builds/#/builders/2/builds/2417 |
|
Of course, because flatpak-builder in this configuration will download everything first, then do the sequential build steps, and not download, build, download, build, etc. I'll have to try and find a work-around for this, maybe a git mirror, or adding hg support to flatpak-builder (but then it'd need to be in the SDK somehow). If anyone has ideas... |
|
Is there any reason not to add an archive of the commit to the PR? |
|
It needlessly increases the size of git repo with no way out in the future (as we disallow forcing pushes). |
|
Note that this won't work without this patch to And that I still get warnings: Unity extensions. Should those be warnings? The only icon file lives in |
|
AFAIK, icons should live in |
|
Yeah, pixmaps isn't sufficient anymore. |
|
Why is that now a requirement? Flatpak used to export those files just fine. And when the application has a single icon... |
|
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html mentions that PREFIX/share/icons is preferred and only mentions /usr/share/pixmaps, (not even PREFIX/share/pixmaps) as fallback. |
|
Was removed in: I can used /apps/pixmaps/icons instead. I'll do that once I've worked on the flatpak-builder patch some more. Edit: I can use |
|
bot, build net.sourceforge.Teo |
|
Failed with: There's a bug in the git-init patch I made for flatpak-builder. Or we could add info for git-commit to work in Flathub, not sure. |
|
I've worked around the |
|
bot, build net.sourceforge.Teo |
Yep, the I've updated the flatpak-builder patch and fully tested it now, so we'll just have to wait for it before merging this. If someone has other ideas to work-around the problem... |
|
Sounds like we might have to wait until 1.0.1 then (plus rollout time). |
It's now merged, just need to wait for a release and roll-out. |
|
bot, build net.sourceforge.Teo |
|
Repository has been created: https://github.com/flathub/net.sourceforge.Teo |
The screenshots might be a bit small...