Add dev.sparcles.SREngine by innerviewer · Pull Request #5482 · flathub/flathub

innerviewer · 2024-08-05T15:25:29Z

Please describe the application briefly.
2D/3D game engine.
The domain used for the application ID is controlled by the application developers and the application id guidelines are followed.
I have read the and followed all the Submission and licence requirements.
I have built and tested the submission locally.
I am an author/developer/upstream contributor of the project.

This is my first time creating and building an application with Flatpak. I'd like to know where to put the resources needed for the engine (shaders, icons, etc.). As you can see, the resource folder is in the git repository and I am currently copying it to /app/share/SREngine/Resources for later use.
There is also a problem with the file system. The application does not have permissions to make changes in the sandbox.

As I have no experience with manifests, I would appreciate some feedback.

innerviewer · 2024-08-05T15:56:21Z

OK, thanks! I'll see what I can do right after I merge the engine's dev branch into master for some necessary changes.

innerviewer · 2024-08-05T20:34:57Z

bot, build dev.sparcles.SREngine

flathubbot · 2024-08-05T20:34:59Z

Queued test build for dev.sparcles.SREngine.

flathubbot · 2024-08-05T20:35:24Z

Started test build 138374

flathubbot · 2024-08-05T20:45:29Z

Build 138374 failed

innerviewer · 2024-08-05T20:46:07Z

bot, build dev.sparcles.SREngine

flathubbot · 2024-08-05T20:46:09Z

Queued test build for dev.sparcles.SREngine.

flathubbot · 2024-08-05T20:46:42Z

Started test build 138377

flathubbot · 2024-08-05T20:57:24Z

Build 138377 failed

(Manifest) Added filesystem permissions to build module. (Flathub) Added desktop, metainfo and logo files.

bbhtt · 2024-08-12T04:23:27Z

Icon, desktop file and metainfo file should be upstream.

innerviewer · 2024-08-12T18:39:14Z

Icon, desktop file and metainfo file should be upstream.

Do you mean that I should push it to the engine's repo?

flathubbot · 2024-08-14T02:18:13Z

Queued test build for dev.sparcles.SREngine.

flathubbot · 2024-08-14T02:18:25Z

Started test build 140108

flathubbot · 2024-08-14T02:27:05Z

Build 140108 failed

bbhtt · 2024-08-14T02:34:48Z

You have to remove the icon key in metainfo, that's causing the failure. That's not needed for desktop applications.

innerviewer · 2024-08-14T02:37:18Z

You have to remove the icon key in metainfo, that's causing the failure. That's not needed for desktop applications.

Done, thank you.

bbhtt · 2024-08-14T02:38:15Z

bot, build dev.sparcles.SREngine

categories in metainfo will override the ones in desktop file, you can set it in either place. The issue was icon tag.

flathubbot · 2024-08-14T02:38:17Z

Queued test build for dev.sparcles.SREngine.

flathubbot · 2024-08-14T02:38:29Z

Started test build 140111

flathubbot · 2024-08-14T02:49:35Z

Build 140111 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/123155/dev.sparcles.SREngine.flatpakref

bbhtt · 2024-08-14T15:52:54Z

Seems to crash immediately in a GNOME Boxes VM running Fedora 40, GNOME 47 wayland

test@fedora:~$ flatpak run dev.sparcles.SREngine
Tracy Profiler initialization failure: CPU doesn't support invariant TSC.
Define TRACY_NO_INVARIANT_CHECK=1 to ignore this error, *if you know what you are doing*.
Alternatively you may rebuild the application with the TRACY_TIMER_FALLBACK define to use lower resolution timer.
Platform::InitializePlatform() : initializing Linux platform...
<25400 KB> [Debug] [140139491709440] Debugger has been initialized. 
	Log path: /home/test/.var/app/dev.sparcles.SREngine/data/srengine-log.txt
<25528 KB> [Info] [140139491709440] Build Info: '3e4e1f1' in 'HEAD' (dirty: true) by 'innerviewer' on
	Wed Aug 14 02:36:21 2024

<25784 KB> [System] [140139491709440] Application::Init() : initializing application...
<25784 KB> [Log] [140139491709440] Thread::Factory::SetMainThread() : initializing main thread...
<25912 KB> [Log] [140139491709440] Thread::Factory::SetMainThread() : main thread id: "140139491709440"
<26040 KB> [Log] [140139491709440] Features::Reload() : features are successfully reloaded!
<26040 KB> [Info] [140139491709440] ResourceManager::Init() : initializing resource manager...
	Resources folder: /home/test/.var/app/dev.sparcles.SREngine/data/Resources
<26040 KB> [Log] [140139491709440] Thread::Factory::Create() : creating new "140139334469312" thread...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle5Utils5Types7RawMeshE" type...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle5Utils8SettingsE" type...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle5Utils6PrefabE" type...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle5Utils4SRLM14LogicalMachineE" type...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle8Graphics12FileMaterialE" type...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle8Graphics5Types4MeshE" type...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle8Graphics5Types7TextureE" type...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle8Graphics5Types6ShaderE" type...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle8Graphics5Types6SkyboxE" type...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle8Graphics5Types11FramebufferE" type...
<26040 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle8Graphics5Types4FontE" type...
<26168 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle9Scripting12EvoBehaviourE" type...
<26168 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle5Audio5SoundE" type...
<26168 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle5Audio8RawSoundE" type...
<26296 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle8Graphics10Animations13AnimationClipE" type...
<26296 KB> [Info] [140139491709440] ResourceManager::RegisterType() : registering new "N7SpaRcle7Physics5Types15PhysicsMaterialE" type...
<26424 KB> [Log] [140139491709440] Settings::Reload() : reloading "Engine/Configs/TagManagerSettings.xml" settings...
<26552 KB> [Log] [140139491709440] Application::Init() : loaded 6 tags.
<26552 KB> [Info] [140139491709440] Engine::Create() : registering all resources...
<26552 KB> [Info] [140139491709440] Engine::Create() : creating main window...
<26552 KB> [Log] [140139491709440] Engine::CreateMainWindow() : trying to find screen resolution...
<26808 KB> [Log] [140139491709440] Engine::CreateMainWindow() : found 1 resolutions
<27064 KB> [Info] [140139491709440] Window::Initialize() : initializing the window...
<27064 KB> [Log] [140139491709440] Engine::CreateMainWindow() : initializing window callbacks...
<27064 KB> [Log] [140139491709440] Engine::RegisterLibraries() : registering all libraries...
<27064 KB> [Info] [140139491709440] EvoCompiler::Init() : initializing compiler...
<27064 KB> [Info] [140139491709440] EvoCompiler::GetGenerator() : using "Visual Studio 16 2019" generator...
<27960 KB> [Log] [140139491709440] TextureLoader::Load() : save texture to cache...
<27960 KB> [Error] [140139491709440] FileBrowser::SetFolder() : path is not folder! 
	Path: /home/test/.var/app/dev.sparcles.SREngine/data/Resources
<27960 KB> [Info] [140139491709440] Engine::Create() : creating game engine...
<27960 KB> [Log] [140139491709440] Scene::New() : creating new scene...
<28088 KB> [Info] [140139491709440] Engine::Init() : initializing game engine...
<28088 KB> [Info] [140139491709440] Engine::Run() : running game engine...
<28088 KB> [Log] [140139491709440] Thread::Factory::Create() : creating new "140139323983552" thread...
<28088 KB> [System] [140139491709440] Application::Init() : all systems started successfully!
<28088 KB> [Info] [140139491709440] Application::Execute() : waiting for the application to close...
<28088 KB> [Log] [140139323983552] Window::Open() : opening the window...
<28472 KB> [Error] [140139323983552] GLFWWindow::Initialize() : failed to initialize GLFW.
<28472 KB> [Error] [140139323983552] Window::ThreadFunction() : failed to initialize window implementation!
<28472 KB> [Error] [140139323983552] Engine::InitializeRender() : failed to open the main window!
<28472 KB> [System] [140139491709440] Engine::Execute() : threads worker is not alive!
<28472 KB> [Log] [140139491709440] ThreadsWorker::Stop() : stopping threads...
<28472 KB> [Log] [140139491709440] Thead::Join() : join thread "Engine" with id "140139323983552"...
<28472 KB> [Log] [140139323983552] ThreadWorker::Work() : finalize state "Initialize"
<28472 KB> [Info] [140139323983552] InitializeState::Finalize() : flushing scene...
<28600 KB> [Info] [140139323983552] DebugRenderer::Init() : initializing debug renderer...
<31520 KB> [Log] [140139323983552] RawMesh::Load() : export model to cache... 
	Path: /home/test/.var/app/dev.sparcles.SREngine/data/Resources/Cache/Models/Engine/Models/cubeWireframe.obj.cache
<48544 KB> [Log] [140139323983552] RawMesh::Load() : export model to cache... 
	Path: /home/test/.var/app/dev.sparcles.SREngine/data/Resources/Cache/Models/Engine/Models/planeWireframe.obj.cache
<64928 KB> [Log] [140139323983552] RawMesh::Load() : export model to cache... 
	Path: /home/test/.var/app/dev.sparcles.SREngine/data/Resources/Cache/Models/Engine/Models/sphere_circle.obj.cache
<64928 KB> [Log] [140139323983552] RawMesh::Load() : export model to cache... 
	Path: /home/test/.var/app/dev.sparcles.SREngine/data/Resources/Cache/Models/Engine/Models/capsule_circle.obj.cache
<65568 KB> [Log] [140139323983552] Settings::Reload() : reloading "Editor/Configs/OverlayRenderTechnique.xml" settings...
<65568 KB> [Info] [140139323983552] PhysicsScene::Init() : initializing the physics scene...
<65568 KB> [Log] [140139323983552] PhysicsMaterial::Load() : the physics material is loading. 
	Path: /home/test/.var/app/dev.sparcles.SREngine/data/Resources/Engine/PhysicsMaterials/DefaultMaterial.physmat
<65568 KB> [Info] [140139323983552] PhysicsLibrary::GetLibrary() : initializing "PhysX" physics library...
<68256 KB> [Info] [140139323983552] Scene::SaveAt() : saving scene...
	Path: Scenes/New-cache-scene.scene
<68256 KB> [Log] [140139323983552] SceneCubeChunkLogic::Destroy() : unload 0 regions...
<68256 KB> [Log] [140139323983552] Scene::Destroy() : complete unloading!
<68256 KB> [Log] [140139323983552] Scene::Destroy() : destroying "New-cache-scene" scene contains 0 game objects...
<68256 KB> [Log] [140139323983552] Scene::Destroy() : scene successfully destroyed!
<68256 KB> [Log] [140139323983552] Scene::~Scene() : free "New-cache-scene" scene pointer...
<68512 KB> [Info] [140139323983552] InitializeState::Finalize() : flushing scene...
<68512 KB> [Log] [140139323983552] RenderContext::Close() : closing render context...
<68512 KB> [System] [140139323983552] RenderContext::Close() : synchronizing resources (step 1)
<68512 KB> [Log] [140139323983552] RenderContext::Update() : destroy render scene...
<68512 KB> [Log] [140139323983552] RenderContext::Close() : render context successfully closed!
<68512 KB> [Log] [140139491709440] Thread::Free() : free "140139323983552" thread...
<68512 KB> [System] [140139491709440] Application::Execute() : engine is not alive!
<68512 KB> [Info] [140139491709440] Engine::Close() : closing game engine...
<68512 KB> [Info] [140139491709440] Engine::Close() : destroying the editor...
<68512 KB> [System] [140139491709440] Engine::Await() : disabling editor gui...
<68512 KB> [Info] [140139491709440] CmdManager::Close() : close the command manager...
<68640 KB> [Info] [140139491709440] VulkanPipeline::Destroy() : destroying vulkan pipeline...
<68768 KB> [Info] [140139491709440] GlobalEvoCompiler::OnSingletonDestroy() : free global compiler...
<68768 KB> [System] [140139491709440] Application::Close() : all systems were successfully closed!
<68768 KB> [Info] [140139491709440] ResourceManager::OnSingletonDestroy() : stopping resource manager...
<68768 KB> [System] [140139491709440] ResourceManager::PrintMemoryDump() : memory dump is empty!
<68768 KB> [Info] [140139491709440] ResourceManager::OnSingletonDestroy() : stopping thread...
<68768 KB> [Log] [140139491709440] Thead::Join() : join thread "Resources manager" with id "140139334469312"...
<68768 KB> [Info] [140139334469312] ResourceManager::Thread() : exit from thread-function.
<68768 KB> [Log] [140139491709440] Thread::Free() : free "140139334469312" thread...
<68768 KB> [System] [140139491709440] ResourceManager::PrintMemoryDump() : memory dump is empty!
<68768 KB> [Debug] [140139491709440] Debugger has been stopped with errors!
	Errors count: 4
	Warnings count: 0

innerviewer · 2024-08-14T18:53:04Z

Seems to crash immediately in a GNOME Boxes VM running Fedora 40, GNOME 47 wayland
<28472 KB> [Error] [140139323983552] GLFWWindow::Initialize() : failed to initialize GLFW.
<28472 KB> [Error] [140139323983552] Window::ThreadFunction() : failed to initialize window implementation!
<28472 KB> [Error] [140139323983552] Engine::InitializeRender() : failed to open the main window!

This seems to be a problem with GLFW on Wayland. Thanks for the feedback. I'll see what I can do.

innerviewer · 2024-08-17T01:49:31Z

Seems to crash immediately in a GNOME Boxes VM running Fedora 40, GNOME 47 wayland

Can you please provide the output of vulkaninfo --summary?
I have tried the same OS as yours both in a virtual machine and on a hard disk. After compiling and debugging, I saw this log:

<99856 KB> [VulkanLog] [140618141533888] [0] Device::Create() : found device - llvmpipe (LLVM 18.1.6, 256 bits)
<99856 KB> [VulkanLog] [140618141533888] [0] Device::Create() : choosing "llvmpipe (LLVM 18.1.6, 256 bits)" device.

And indeed, Vulkan does not see my 1070 Ti on a freshly installed and fully updated Fedora:

Devices:
========
GPU0:
	apiVersion         = 1.3.278
	driverVersion      = 0.0.1
	vendorID           = 0x10005
	deviceID           = 0x0000
	deviceType         = PHYSICAL_DEVICE_TYPE_CPU
	deviceName         = llvmpipe (LLVM 18.1.6, 256 bits)
	driverID           = DRIVER_ID_MESA_LLVMPIPE
	driverName         = llvmpipe
	driverInfo         = Mesa 24.1.5 (LLVM 18.1.6)
	conformanceVersion = 1.3.1.1
	deviceUUID         = 6d657361-3234-2e31-2e35-000000000000
	driverUUID         = 6c6c766d-7069-7065-5555-494400000000

So I think the problem is not just on the engine side. I tried to fix the problem by installing the proprietary drivers, but ran into other Fedora-related problems.

innerviewer · 2024-08-17T02:00:01Z

bot, build dev.sparcles.SREngine

This is for the link to update, as it expires after some time

flathubbot · 2024-08-17T02:00:04Z

Queued test build for dev.sparcles.SREngine.

flathubbot · 2024-08-17T02:07:11Z

Started test build 140722

flathubbot · 2024-08-17T02:19:48Z

Build 140722 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/123770/dev.sparcles.SREngine.flatpakref

bbhtt · 2024-08-17T04:47:48Z

Seems to crash immediately in a GNOME Boxes VM running Fedora 40, GNOME 47 wayland

Can you please provide the output of vulkaninfo --summary? I have tried the same OS as yours both in a virtual machine and on a hard disk. After compiling and debugging, I saw this log:

It doesn't work on my host either

vulkaninfo --summary                                                                                                                                                                                         12s
==========
VULKANINFO
==========

Vulkan Instance Version: 1.3.283


Instance Extensions: count = 24
-------------------------------
VK_EXT_acquire_drm_display             : extension revision 1
VK_EXT_acquire_xlib_display            : extension revision 1
VK_EXT_debug_report                    : extension revision 10
VK_EXT_debug_utils                     : extension revision 2
VK_EXT_direct_mode_display             : extension revision 1
VK_EXT_display_surface_counter         : extension revision 1
VK_EXT_headless_surface                : extension revision 1
VK_EXT_surface_maintenance1            : extension revision 1
VK_EXT_swapchain_colorspace            : extension revision 4
VK_KHR_device_group_creation           : extension revision 1
VK_KHR_display                         : extension revision 23
VK_KHR_external_fence_capabilities     : extension revision 1
VK_KHR_external_memory_capabilities    : extension revision 1
VK_KHR_external_semaphore_capabilities : extension revision 1
VK_KHR_get_display_properties2         : extension revision 1
VK_KHR_get_physical_device_properties2 : extension revision 2
VK_KHR_get_surface_capabilities2       : extension revision 1
VK_KHR_portability_enumeration         : extension revision 1
VK_KHR_surface                         : extension revision 25
VK_KHR_surface_protected_capabilities  : extension revision 1
VK_KHR_wayland_surface                 : extension revision 6
VK_KHR_xcb_surface                     : extension revision 6
VK_KHR_xlib_surface                    : extension revision 6
VK_LUNARG_direct_driver_loading        : extension revision 1

Instance Layers: count = 1
--------------------------
VK_LAYER_MESA_device_select Linux device selection layer 1.3.211  version 1

Devices:
========
GPU0:
	apiVersion         = 1.3.278
	driverVersion      = 24.1.5
	vendorID           = 0x1002
	deviceID           = 0x1638
	deviceType         = PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU
	deviceName         = AMD Radeon Graphics (RADV RENOIR)
	driverID           = DRIVER_ID_MESA_RADV
	driverName         = radv
	driverInfo         = Mesa 24.1.5
	conformanceVersion = 1.2.7.1
	deviceUUID         = 00000000-0a00-0000-0000-000000000000
	driverUUID         = 414d442d-4d45-5341-2d44-525600000000
GPU1:
	apiVersion         = 1.3.278
	driverVersion      = 0.0.1
	vendorID           = 0x10005
	deviceID           = 0x0000
	deviceType         = PHYSICAL_DEVICE_TYPE_CPU
	deviceName         = llvmpipe (LLVM 18.1.6, 256 bits)
	driverID           = DRIVER_ID_MESA_LLVMPIPE
	driverName         = llvmpipe
	driverInfo         = Mesa 24.1.5 (LLVM 18.1.6)
	conformanceVersion = 1.3.1.1
	deviceUUID         = 6d657361-3234-2e31-2e35-000000000000
	driverUUID         = 6c6c766d-7069-7065-5555-494400000000

innerviewer · 2024-08-19T17:50:33Z

bot, build dev.sparcles.SREngine

This is for the link to update, as it expires after some time

flathubbot · 2024-08-19T17:50:35Z

Queued test build for dev.sparcles.SREngine.

flathubbot · 2024-08-19T17:50:47Z

Started test build 141089

flathubbot · 2024-08-19T18:02:27Z

Build 141089 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/124143/dev.sparcles.SREngine.flatpakref

github-actions · 2025-03-19T11:51:01Z

This hasn't received any updates in 6 months and will be
automatically closed in 7 days. Please comment or reopen if
necessary.

innerviewer · 2025-03-24T12:43:24Z

I was taking a break from the project and I was not working on resolving this issue.
We're currently headed towards our 1.0.0 release and I am planning on fixing everything before then.

github-actions · 2025-09-28T05:12:31Z

This pull request has not received any updates and it will be
automatically closed in 7 days. Please comment or reopen if
necessary.

innerviewer added 5 commits August 2, 2024 18:01

(Git) Initial commit.

f10fd26

(Build) Fixed build and got rid of python modules.

c09c69e

(Manifest) Changed the ID and fixed build errors.

6fecbcc

(Flatpak) Deleted python modules.

fb36c4e

(Manifest) Changed the branch to master.

a1417fe

hfiguiere reviewed Aug 5, 2024

View reviewed changes