Add org.kde.kwave

[mrpenner]

Please confirm your submission meets all the criteria

• Please describe the application briefly. Audio editor
• The domain used for the application ID is controlled by the application developer(s) and the application id guidelines are followed.
• I have read and followed all the Submission requirements and the Submission guide.
• I have built and tested the submission locally.
• I am an author/developer/upstream contributor to the project. If not, I contacted upstream developers about this submission. Link:

[mrpenner]

This is currently building from a git commit, so it should either wait until the next release (in April) or only go to beta. I wanted to get this started so I could make any needed changes and make sure it's ready for merging at the next stable release, when I can switch to building from the released archive. The reason I'm not using the current stable release is because https://invent.kde.org/multimedia/kwave/-/merge_requests/32 is needed to use the file portal.

[mrpenner]

There was a previous effort: #2848 but it seems to have stalled

[hfiguiere]

cc @flathub/kde

[Justinzobel]

@milohr would be best to test this as the primary architect behind the Maui Project.

[mrpenner]

@milohr would be best to test this as the primary architect behind the Maui Project.

Kwave is not related to the Maui Project. Were you thinking of Vvave?

[Justinzobel]

Yeah that's the one, so many audio apps! Oops!

[bbhtt]

This is currently building from a git commit, so it should either wait until the next release (in April) or only go to beta.

Better to wait as there is no automatic transition for users from beta repo to stable.

[bbhtt]

bot, build org.kde.kwave

[flathubbot]

Queued test build for org.kde.kwave.

[flathubbot]

Started test build 172237

[flathubbot]

Build 172237 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/155355/org.kde.kwave.flatpakref

[mrpenner]

bot, build org.kde.kwave

[flathubbot]

Queued test build for org.kde.kwave.

[flathubbot]

Started test build 172673

[flathubbot]

Build 172673 failed

[mrpenner]

bot, build org.kde.kwave

[flathubbot]

Queued test build for org.kde.kwave.

[flathubbot]

Started test build 172680

[flathubbot]

Build 172680 failed

[mrpenner]

I was sourcing id3lib from https://github.com/thekhalifa/id3lib. I noticed the Kwave flatpak wasn't saving ID3 tags properly, so I switched to the released version of id3lib from SourceForge plus some patches from Debian. My local build now saves the ID3 tags properly.

I see the bot build failed to build id3lib on aarch64. Shall I just disable aarch64 builds?

I know it's not great to use such an old library that needs so many patches. I would like to port Kwave to TagLib, but I'm not sure when I can get that done.

[Justinzobel]

I have no preference one way or the other.

On the one hand it would be nice to have Kwave in Flathub so we keep the KDE Flatpak train going.

On the other hand, old libraries + patches = maintenance cost, so waiting for the work on supporting TagLib would be good.

[jbruechert]

I think you may need to run autoreconf -fi before building id3lib to fix the aarch64 build.

I guess aarch64 didn't really exist in 2003

[flathubbot]

Queued test build for org.kde.kwave.

[flathubbot]

Started test build 181178

[flathubbot]

Build 181178 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/164339/org.kde.kwave.flatpakref

[mrpenner]

bot, build org.kde.kwave

[flathubbot]

Queued test build for org.kde.kwave.

[flathubbot]

Started test build 193152

[flathubbot]

Build 193152 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/176443/org.kde.kwave.flatpakref

[mrpenner]

I updated to the release candidate (v25.03.90) archive and tested the build, and it seems to work fine. 25.04 release is April 17, is there anything I need to do before then? Just update the archive URL when 25.04 is released?

[bbhtt]

Just update the archive URL when 25.04 is released?

Yes

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/178526/org.kde.kwave.flatpakref

[mrpenner]

AFAIK this is good to go. The test build works fine for me.

[bbhtt]

Seems fine, cc @flathub/kde for a final review?

[tsdgeos]

Oh my sadness so many patches.

[tsdgeos]

Can we please get anitya (or any other kind of x-checker-data) so we get automatic MRs when there's new versions of the tarballs released?

You can get inspired by the okular ones https://github.com/flathub/org.kde.okular/blob/master/org.kde.okular.json

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[mrpenner]

Can we please get anitya (or any other kind of x-checker-data)

I added anitya for KWave. For the dependencies, id3lib isn't going to get any more releases and libaudiofile is also looking that way. (And I share your sadness that so many patches are needed. Maybe someday I can get KWave ported to taglib or something.)

I see there's a shared module for libmad, should I be using that?

[flathubbot]

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/178929/org.kde.kwave.flatpakref

[tsdgeos]

The problem with the shared module is that we don't get updates to it, so i guess unless the compilation for it is super complicated (which seems not) i would not do it.

Looks reasnoable to me now :)

[bbhtt]

/merge

[flathubbot]

A repository for this submission has been created: https://github.com/flathub/org.kde.kwave and it will be published to Flathub in 4-5 hours.

You will receive an invite to be a collaborator to the above repository. Please make sure to enable 2FA on GitHub and accept the invite within one week.

Please go through the App maintenance guide if you have never maintained an app on Flathub before.

If you're the original developer (or an authorized party), please verify your app to let users know it's coming from you.

Please follow the Flathub blog for the latest announcements.

Thanks!