New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gcolor3 #601

Closed
wants to merge 1 commit into
base: new-pr
from

Conversation

2 participants
@Hjdskes

Hjdskes commented Sep 1, 2018

Gcolor3 is my color picking application for the GNOME desktop environment.

@@ -0,0 +1,45 @@
{
"app-id": "nl.hjdskes.gcolor3",

This comment has been minimized.

@TingPing

TingPing Sep 1, 2018

Member

Just for consistency lets remove the extra whitespace.

"finish-args": [
"--share=ipc",
"--socket=x11",
"--socket=wayland",

This comment has been minimized.

@TingPing

TingPing Sep 1, 2018

Member

Since this doesn't actually work on Wayland perhaps just remove this?

This comment has been minimized.

@Hjdskes

Hjdskes Sep 1, 2018

This still allows users to use the wheel, save colors and browse saved colors. They just can't pick a color, yet.

This comment has been minimized.

@TingPing

This comment has been minimized.

@Hjdskes

Hjdskes Sep 1, 2018

What do I need that for? It's working fine for me in Wayland at the moment without dconf access.

This comment has been minimized.

@TingPing

TingPing Sep 1, 2018

Member

GTK on Wayland uses DConf.

"--socket=x11",
"--socket=wayland",
"--filesystem=xdg-config/gcolor3:rw"

This comment has been minimized.

@TingPing

TingPing Sep 1, 2018

Member

Remove this. You already get your own private config dir.

{
"name": "gcolor3",
"buildsystem": "meson",
"builddir": true,

This comment has been minimized.

@TingPing

TingPing Sep 1, 2018

Member

Can remove this, it is forced on for meson.

@TingPing

This comment has been minimized.

Member

TingPing commented Sep 1, 2018

✔️ Upstream appdata file looks good

@Hjdskes

This comment has been minimized.

Hjdskes commented Sep 1, 2018

Force pushed fixes for the feedback.

"runtime": "org.gnome.Platform",
"runtime-version": "3.28",
"sdk": "org.gnome.Sdk",

This comment has been minimized.

@TingPing

TingPing Sep 1, 2018

Member

I mean't all the extra whitespace

},
"cleanup": [
"*.la",

This comment has been minimized.

@TingPing

TingPing Sep 1, 2018

Member

Remove unused cleanup rules.

],
"build-options": {
"cflags": "-O2 -g"

This comment has been minimized.

@TingPing

TingPing Sep 1, 2018

Member

Can just remove this and use this on your gcolor module:

"config-opts": [
  "--buildtype=debugoptimized"
]
@Hjdskes

This comment has been minimized.

Hjdskes commented Sep 1, 2018

Thanks, commit ammended again.

"runtime-version": "3.28",
"sdk": "org.gnome.Sdk",
"command": "gcolor3",

This comment has been minimized.

@TingPing

TingPing Sep 1, 2018

Member

There seems to be a misunderstanding here. When I said remove the white space I meant all of these empty lines you have.

This comment has been minimized.

@Hjdskes

Hjdskes Sep 1, 2018

Ah, misunderstanding indeed.

@Hjdskes

This comment has been minimized.

Hjdskes commented Sep 1, 2018

All whitespace removed and DConf added.

@TingPing

This comment has been minimized.

Member

TingPing commented Sep 1, 2018

bot, build nl.hjdskes.gcolor3

@TingPing

This comment has been minimized.

Member

TingPing commented Sep 1, 2018

Repository has been created: https://github.com/flathub/nl.hjdskes.gcolor3

@TingPing TingPing closed this Sep 1, 2018

@Hjdskes

This comment has been minimized.

Hjdskes commented Sep 1, 2018

Thanks!

@Hjdskes Hjdskes deleted the Hjdskes:gcolor3 branch Sep 1, 2018

Hjdskes added a commit to Hjdskes/gcolor3 that referenced this pull request Sep 2, 2018

@Hjdskes Hjdskes referenced this pull request Sep 5, 2018

Merged

Flatpak support #235

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment