New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add net.sourceforge.qtpfsgui.LuminanceHDR #715
add net.sourceforge.qtpfsgui.LuminanceHDR #715
Conversation
rename-appdata-file: luminance-hdr.appdata.xml | ||
rename-icon: luminance-hdr | ||
finish-args: | ||
- "--socket=fallback-x11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need quotes here for strings
commit: e7ffd83af29187190da7f98dcbca8a4d70e19582 | ||
|
||
- name: fftw3 | ||
buildsystem: autotools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed, it's the default buildsystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, it's better to state it explicitly, just in case default will change as well as others could understand what is going on easier (without the need to remember what are the defaults).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except, default won't change unless meson take over the control of all the buildsystems out there :p if you take a look at the manifest, sometimes they mention the buildsystem: autotools and sometimes they don't :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't expect the default to ever change, but its not a blocker or anything if prefered.
buildsystem: cmake | ||
sources: | ||
- type: git | ||
url: "https://github.com/Exiv2/exiv2/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The url tags don't require quotes too.
rename-appdata-file: luminance-hdr.appdata.xml | ||
rename-icon: luminance-hdr | ||
finish-args: | ||
- "--socket=fallback-x11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fallback-x11 only makes sense if you also have wayland.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding this, as far as I've been told,
Qt5 has a wayland backend so it can run on wayland
However neither @fcomida nor me running wayland. Thus we are not sure whether in modern distros
qt5 apps are run through wayland, and how flatpak interacts with wayland.
@TingPing can you help us to figure that out?
Are you involved with upstream or have you seem if they would be interested in being involved with this? |
I am actually the main developer of Luminance HDR so yes, upstream is definitely involved. |
Strings in yaml may not be quoted
cmake-ninja is more modern buildsystem with more features, why not use it.
bot, build net.sourceforge.qtpfsgui.LuminanceHDR |
@TingPing is everything covered in this PR? Or there are any changes we have to make in order to complete the package? |
rename-appdata-file: luminance-hdr.appdata.xml | ||
rename-icon: luminance-hdr | ||
finish-args: | ||
- --socket=fallback-x11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need --share=ipc if you want to use X11: http://docs.flatpak.org/en/latest/sandbox-permissions-reference.html?highlight=ipc#f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Was not careful enough when reading that part of documentation
@anxolerd By taking a look at the appdata and the desktop file, there are somethings that should be patched upstream.
The desktop file should be renamed too, the same for the icons. The |
Plus, you seem to be shipping the only 48px size of the icon, shipping other sizes would be nice! 128px is used on Flathub for example or you can just ship an SVG icon instead. |
You can also just run |
- add `--share=ipc` permission, as it is required when working with X11 (for better performance) - add `--share=network` permission as > there's a link on Help Browser pointing to the PayPal donation page > LHDR also checks for new versions on SF
Also Qt5 renders the UI via OpenGL if present and falls back to software rendering. Add dri permission to fasten up renders using OpenGL
@bilelmoussaoui do I get it right that changes you suggest in #715 (comment) should be also done in the original app distribution as well? |
bot, build net.sourceforge.qtpfsgui.LuminanceHDR |
As of flathub#715 (comment) provide replacements for appdata.xml, .desktop files and icons to comply.
@bilelmoussaoui I've tried to address your comment in aef90f5 . @fcomida please check whether I stated all the information about LHDR(LuminanceHDR) correctly. |
I integrated all changes in appdata file upstream, thank you. |
bot, build net.sourceforge.qtpfsgui.LuminanceHDR |
- --filesystem=home | ||
- --share=network | ||
- --device=dri | ||
modules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect everything could use some cleanups of development headers etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bilelmoussaoui regarding this, is flatpak-builder run...
sufficient to look what's inside the built container? Or there is better option for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, or you can inspect builddir/files
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What @barthalion suggested is perfect for this. A huge + if you can split the cleanup per module and put the common ones on the top cleanup, it's not a requirement, just a suggestion :)
In general only cleanups are a blocker, otherwise looks good to me. |
Delete files which were required for build only and are not needed for final distribution
@barthalion I've added cleanups as requested. Sorry for the delay. |
bot, build net.sourceforge.qtpfsgui.LuminanceHDR |
post-install: | ||
- install -Dm 644 net.sourceforge.qtpfsgui.LuminanceHDR.appdata.xml -t /app/share/appdata | ||
- install -Dm 644 net.sourceforge.qtpfsgui.LuminanceHDR.desktop -t /app/share/applications | ||
- install -Dm 644 net.sourceforge.qtpfsgui.LuminanceHDR.svg -t /app/share/icons/hicolor/scalable/apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to refresh the icon cache here, otherwise the icon might not show up
As of flathub/flathub#715 (comment) provide replacements for appdata.xml, .desktop files and icons to comply.
Repository has been created: https://github.com/flathub/net.sourceforge.qtpfsgui.LuminanceHDR |
Pull request for adding Luminance HDR to FlatHub