New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.kiwix.Client application to flathub. #768

Open
wants to merge 1 commit into
base: new-pr
from

Conversation

3 participants
@mgautierfr
Copy link

mgautierfr commented Dec 11, 2018

The manifest (and the patches) are generated by kiwix-build
(github kiwix/kiwix-build).

Kiwix is a application to allow offline access to content archive (zim),
as Wikipedia, Stackoverflow, ...

The flatpak bundle of the application can already be found at
http://download.kiwix.org/release/kiwix-desktop/org.kiwix.Client.2.0-beta1.flatpak

@barthalion

This comment has been minimized.

Copy link
Member

barthalion commented Dec 11, 2018

testbot, build org.kiwix.Client

@flathubbot

This comment has been minimized.

Copy link

flathubbot commented Dec 11, 2018

NOTE: This comment was posted by the test instance of buildbot

Queued test build for org.kiwix.Client.

@flathubbot

This comment has been minimized.

Copy link

flathubbot commented Dec 11, 2018

NOTE: This comment was posted by the test instance of buildbot

Started test build 247

@flathubbot

This comment has been minimized.

Copy link

flathubbot commented Dec 11, 2018

NOTE: This comment was posted by the test instance of buildbot

Build 247 failed

Show resolved Hide resolved manifest.json Outdated
"runtime-version": "5.11",
"sdk": "org.kde.Sdk",
"command": "kiwix-desktop",
"rename-desktop-file": "kiwix-desktop.desktop",

This comment has been minimized.

@barthalion

barthalion Dec 11, 2018

Member

Ideally these should get renamed in upstream repo.

This comment has been minimized.

@mgautierfr

mgautierfr Dec 12, 2018

I'm not sure about this.
The project is named kiwix-desktop and it can be installed another way that with flathub.
(We create appimage already and may create "classic" packages)
I prefer to keep a generic name in upstream repository and have flatpak specific name in the flatpak side.

This comment has been minimized.

@barthalion

barthalion Dec 12, 2018

Member

It's mentioned in desktop launcher and appdata specifications that appid form is recommended. It's not flatpak specific.

This comment has been minimized.

@mgautierfr

mgautierfr Dec 12, 2018

But we use appid only in flatpak. Everywhere else, the name is kiwix-desktop.

Show resolved Hide resolved manifest.json Outdated
Show resolved Hide resolved manifest.json Outdated

@mgautierfr mgautierfr force-pushed the kiwix:org.kiwix.Client branch from a32de35 to 2f052bc Dec 12, 2018

@mgautierfr mgautierfr referenced this pull request Dec 12, 2018

Merged

Fix flatpak #275

@barthalion

This comment has been minimized.

Copy link
Member

barthalion commented Dec 12, 2018

testbot, build org.kiwix.Client

@flathubbot

This comment has been minimized.

Copy link

flathubbot commented Dec 12, 2018

NOTE: This comment was posted by the test instance of buildbot

Queued test build for org.kiwix.Client.

@flathubbot

This comment has been minimized.

Copy link

flathubbot commented Dec 12, 2018

NOTE: This comment was posted by the test instance of buildbot

Started test build 269

@flathubbot

This comment has been minimized.

Copy link

flathubbot commented Dec 12, 2018

NOTE: This comment was posted by the test instance of buildbot

Build 269 failed

Add org.kiwix.desktop application to flathub.
The manifest (and the patches) are generated by kiwix-build
(github kiwix/kiwix-build).

Kiwix is a application to allow offline access to content archive (zim),
as Wikipedia, Stackoverflow, ...

The flatpak bundle of the application can already be found at
http://download.kiwix.org/release/kiwix-desktop/org.kiwix.desktop.2.0-beta2.flatpak

@mgautierfr mgautierfr force-pushed the kiwix:org.kiwix.Client branch from 2f052bc to 5302e4d Jan 7, 2019

@mgautierfr

This comment has been minimized.

Copy link

mgautierfr commented Jan 7, 2019

Last forced push rename the app from org.kiwix.Client to org.kiwix.desktop. Do I need to create another PR or it is ok ?

{
"app-id": "org.kiwix.desktop",
"runtime": "org.kde.Platform",
"runtime-version": "5.11",

This comment has been minimized.

@barthalion

barthalion Jan 7, 2019

Member

Would be nice to switch to 5.12, it's out since 2 weeks or so.

{
"type": "git",
"url": "https://github.com/kiwix/kiwix-desktop.git",
"tag": "2.0-beta2"

This comment has been minimized.

@barthalion

barthalion Jan 7, 2019

Member

Specific commits are preferred as tags can be modified to point to different commit.

@barthalion

This comment has been minimized.

Copy link
Member

barthalion commented Jan 7, 2019

It's okay, branch name is irrelevant for anything but our convenience.

testbot, build org.kiwix.desktop

@flathubbot

This comment has been minimized.

Copy link

flathubbot commented Jan 7, 2019

NOTE: This comment was posted by the test instance of buildbot

Queued test build for org.kiwix.desktop.

@flathubbot

This comment has been minimized.

Copy link

flathubbot commented Jan 7, 2019

NOTE: This comment was posted by the test instance of buildbot

Started test build 1041

@flathubbot

This comment has been minimized.

Copy link

flathubbot commented Jan 7, 2019

NOTE: This comment was posted by the test instance of buildbot

Build 1041 failed

@barthalion

This comment has been minimized.

Copy link
Member

barthalion commented Jan 13, 2019

Looks like appdata file is missing. I see it in your repo; should it be installed by build system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment