Remove access to whole filesystem #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> The filesystem=host permission got copied from upstream/Flathub https://github.com/flathub/org.gnome.Evince/blob/master/org.gnome.Evince.json#L13 > It seems that revoking that permission doesn't cause any problem with the app's main functionality. https://bugzilla.redhat.com/show_bug.cgi?id=2098179 Ref upstream also did not explain why/how this permission would be needed: https://gitlab.gnome.org/GNOME/evince/-/issues/1810
|
Started test build 99575 |
|
Ah just saw #76, anyway I see no big open issue there preventing this. |
|
Build 99575 successful |
If you read it, you will find this comment: #76 (comment) Also, there are other PRs for this: #61 and #88. There is also another issue: see flatpak/xdg-desktop-portal#807 and https://gitlab.gnome.org/GNOME/libdazzle/-/issues/65 |
|
Thanks for the patch. I merged #88 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimizing permissions is always a good idea.
Why do you now need access to all files? Is not the idea that exploits or so in a PDF viewer could be mitigated/not have such a bad effect if it does not have access to all files?
https://bugzilla.redhat.com/show_bug.cgi?id=2098179
Ref upstream also did not explain why/how this permission would be needed: https://gitlab.gnome.org/GNOME/evince/-/issues/1810
Fixes #76