Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v3.32.0 #9

Merged
merged 8 commits into from May 24, 2019

Conversation

@anton-z-s
Copy link
Contributor

commented May 23, 2019

No description provided.

@flathubbot

This comment has been minimized.

Copy link

commented May 23, 2019

Started test build 3852

@flathubbot

This comment has been minimized.

Copy link

commented May 23, 2019

Build 3852 failed

@flathubbot

This comment has been minimized.

Copy link

commented May 23, 2019

Started test build 3853

@flathubbot

This comment has been minimized.

Copy link

commented May 23, 2019

Build 3853 failed

@flathubbot

This comment has been minimized.

Copy link

commented May 23, 2019

Started test build 3855

@flathubbot

This comment has been minimized.

Copy link

commented May 23, 2019

Build 3855 failed

@flathubbot

This comment has been minimized.

Copy link

commented May 23, 2019

Started test build 3857

@anton-z-s

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

Probably have to wait until https://gitlab.gnome.org/GNOME/gitg/merge_requests/71 is merged

@flathubbot

This comment has been minimized.

Copy link

commented May 23, 2019

Build 3857 failed

@albfan

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2019

Thanks for all the patches, I think we need to enable strict validation to avoid those metadata errors.

https://gitlab.gnome.org/GNOME/gitg/merge_requests/71

I will try to fix ASAP

org.gnome.gitg.json Outdated Show resolved Hide resolved
org.gnome.gitg.json Outdated Show resolved Hide resolved
@flathubbot

This comment has been minimized.

Copy link

commented May 24, 2019

Started test build 3867

Apply suggestions from code review
Co-Authored-By: Bilal Elmoussaoui <bil.elmoussaoui@gmail.com>
@flathubbot

This comment has been minimized.

Copy link

commented May 24, 2019

Started test build 3868

@flathubbot

This comment has been minimized.

Copy link

commented May 24, 2019

Build 3868 failed

@flathubbot

This comment has been minimized.

Copy link

commented May 24, 2019

Build 3867 failed

@albfan

This comment has been minimized.

Copy link
Collaborator

commented May 24, 2019

 argv: b'flatpak run org.freedesktop.appstream-glib validate builddir/*/share/appdata/org.gnome.gitg.appdata.xml'
 using PTY: False
builddir/files/share/appdata/org.gnome.gitg.appdata.xml: FAILED:
• tag-missing           : <name> is not present
• tag-missing           : <summary> is not present
Validation of files failed

https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html

Summary can be like description (or just first paragraph) and name "gitg"

Please create the patch and create a MR on gitg too (afk)

@flathubbot

This comment has been minimized.

Copy link

commented May 24, 2019

Started test build 3872

@flathubbot

This comment has been minimized.

Copy link

commented May 24, 2019

Build 3872 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/3697/org.gnome.gitg.flatpakref
@albfan
albfan approved these changes May 24, 2019
@flathubbot

This comment has been minimized.

Copy link

commented May 24, 2019

Started test build 3873

@flathubbot

This comment has been minimized.

Copy link

commented May 24, 2019

Build 3873 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/3698/org.gnome.gitg.flatpakref
@albfan

This comment has been minimized.

Copy link
Collaborator

commented May 24, 2019

Thanks for all the hard work!

@albfan albfan merged commit fc419bd into flathub:master May 24, 2019

5 checks passed

builds/aarch64 Build done.
Details
builds/arm Build done.
Details
builds/i386 Build done.
Details
builds/x86_64 Build done.
Details
download-sources Build done.
Details
clrpackages pushed a commit to clearlinux-pkgs/gitg that referenced this pull request Jul 29, 2019
[update to 3.32.1] Support repository being null
Alberto Fanjul (2):
      Metadata for release 3.32.0
      Release version 3.32.1

Aurimas Černius (1):
      Updated Lithuanian translation

Balázs Úr (1):
      Update Hungarian translation

Daniel Șerbănescu (1):
      Update Romanian translation

Gaurav Agrawal (2):
      commit-dialog: Allow copying the file names
      Support repository being null

Matej Urbančič (1):
      Updated Slovenian translation

Milo Casagrande (1):
      Update Italian translation

Piotr Drąg (1):
      Update Polish translation

Rafael Fontenelle (1):
      Update Brazilian Portuguese translation

anton-z-s (1):
      Update org.gnome.gitg.appdata.xml.in.in to pass validation on flatpak. flathub/org.gnome.gitg#9 (comment)

= gitg 3.32.1 =
Version 3.32.1 was released on 2019-07-25

== Bugs fixed ==
- Support repository being null
- Allow copying file names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.