Vaapi not working

[frdbr]

For VAAPI to work we must include:

• libva
• Intel(R) Media Driver for VAAPI
• Intel(R) Graphics Memory Management Library
• Intel® Media SDK
• Intel-vaapi-driver

Also ffmpeg must be built with the following flags:

--extra-cflags="-I/usr/local/include" \
--extra-ldflags="-L/usr/local/lib" \
--enable-libmfx
--enable-vaapi

[Erick555]

See #111 (comment)

--extra-cflags="-I/usr/local/include"
--extra-ldflags="-L/usr/local/lib" \

There is no /usr/local path in flatpak so this doesn't make any sense.

--enable-vaapi

it's already there.

[frdbr]

See #111 (comment)

--extra-cflags="-I/usr/local/include"
--extra-ldflags="-L/usr/local/lib" \

There is no /usr/local path in flatpak so this doesn't make any sense.

How can I point to the libs then? Where are they located at?

--enable-vaapi

it's already there.

Yes, we only need libmfx now.

[Erick555]

How can I point to the libs then? Where are they located at?

Libs are in /app/lib and /usr/lib but they should be detected automatically, why do you think you need setting them?

[frdbr]

How can I point to the libs then? Where are they located at?

Libs are in /app/lib and /usr/lib but they should be detected automatically, why do you think you need setting them?

This is how ffmpeg works it seems, one needs to explicitly pass this instructions at config stage. It is also the case for nvidia:

--extra-cflags=-I/usr/local/cuda/include 
--extra-ldflags=-L/usr/local/cuda/lib64

[frdbr]

@Erick555 should I send a mr for intel-media-sdk or shall I open a request at freedesktop to include it?

[Erick555]

This is how ffmpeg works it seems, one needs to explicitly pass this instructions at config stage. It is also the case for nvidia:

Do you have any example of something isn't working without this currently? There are couple of ffmpeg deps build here and there are no extra-cflags set so either ffmpeg is broken right now or you don't need to set those options.

I didn't saw any other app that build ffmpeg setting such options.

[frdbr]

This is how ffmpeg works it seems, one needs to explicitly pass this instructions at config stage. It is also the case for nvidia:

Do you have any example of something isn't working without this currently? There are couple of ffmpeg deps build here and there are no extra-cflags set so either ffmpeg is broken right now or you don't need to set those options.

I didn't saw any other app that build ffmpeg setting such options.

I will add these changes to Kdenlive's flatpak nightly and ask some testing from the community to see if it works without the extra-cflags. But afaik this is the recommended way of doing in the ffmpeg docs and nvidia docs (as well as many posts on stackoverflow.)

[Erick555]

It may be recommended when something doesn't work. You didn't specified what doesn't work right now and you want to provide solution without stating what the problem is.

You don't need people to test this as it's enough to read the buildlog where you can see if ffmpeg can see external libraries or if it can't. You may also see that flatpak sets LDFLAGS=-L/app/lib, LD_LIBRARY_PATH=/app/lib,and PKG_CONFIG_PATH=/app/lib/pkgconfig:/app/share/pkgconfig automatically so if you not inventing some fancy install prefixes for libraries they should be detected ootb. Only when they aren't you may try hacks from stackoverflow or elsewhere.

[frdbr]

The official documentation for both intel and nvidia recommend adding the extra flags. Will keep testing and if we encounter issues will open a new report.

Closed via #115