Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime to 40, application to git, update dbus-python a bit #5

Closed
wants to merge 2 commits into from

Conversation

lionirdeadman
Copy link

This application being changed to git will need testing.

I've changed to git because :

It has python 3 fixes (#4)
It handles the presence of gtk4

@flathubbot
Copy link

Started test build 48484

@flathubbot
Copy link

Build 48484 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/46625/org.laptop.TurtleArtActivity.flatpakref

@barthalion
Copy link
Member

cc @tchx84

@tchx84
Copy link
Collaborator

tchx84 commented May 19, 2021

A few comments:

  • The media palette is broken (it's a regression, see images below)

image

vs

image

Traceback (most recent call last):
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 1241, in _buttonpress_cb
    self.button_press(
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 1311, in button_press
    elif self._check_for_anything_else(spr, x, y):
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 1624, in _check_for_anything_else
    self._select_category(spr)
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 1794, in _select_category
    self.show_palette(i)
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 987, in show_palette
    self.show_toolbar_palette(n)
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 1097, in show_toolbar_palette
    self.palette_views[n].create(regenerate=regenerate, show=show)
  File "/app/lib/python3.8/site-packages/TurtleArt/tapaletteview.py", line 64, in create
    self._create_proto_blocks()
  File "/app/lib/python3.8/site-packages/TurtleArt/tapaletteview.py", line 198, in _create_proto_blocks
    self._proto_skin(name + 'small', self.blocks[-1].spr)
  File "/app/lib/python3.8/site-packages/TurtleArt/tapaletteview.py", line 211, in _proto_skin
    x, y = self._turtle_window.calc_image_offset(name, spr)
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 4863, in calc_image_offset
    iw = self.media_shapes[name].get_width()
KeyError: 'camera1small'

@lionirdeadman can you create an upstream issue? https://github.com/sugarlabs/turtleart-activity/issues

  • Numpy is still missing.
Failed to load Audio_sensors: No module named 'numpy'

This should be an easy fix https://github.com/flathub/org.sugarlabs.Speak/blob/master/org.sugarlabs.Speak.json#L27

@flathubbot
Copy link

Started test build 48608

@flathubbot
Copy link

Build 48608 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/46748/org.laptop.TurtleArtActivity.flatpakref

@bbhtt
Copy link
Contributor

bbhtt commented Jul 14, 2022

Hello anyone working on this? 40 is EOL, so ideally the runtime should be bumped to 42 now and the dependencies needs to updated again.

@barthalion
Copy link
Member

No idea if said regression has been fixed. @tchx84?

@nedrichards
Copy link
Member

There's newer git commits upstream at the very least.

@wjt
Copy link
Member

wjt commented Sep 22, 2022

#7 updates to the 42 runtime, and a newer Git snapshot.

@wjt wjt mentioned this pull request Sep 22, 2022
@wjt
Copy link
Member

wjt commented Sep 29, 2022

This can be closed, #7 was merged.

@bbhtt bbhtt closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants