fix cradle.Connection.prototype.replicate() #157

Merged
merged 2 commits into from Jul 30, 2012

Conversation

Projects
None yet
3 participants
Contributor

klaemo commented Mar 8, 2012

  • options belong in the body not the query string
fix cradle.Connection.prototype.replicate()
- options belong in the body not the query string

+1.

Database.prototype.replicate is also broken, trying to use a variable name that doesn't exist instead of this.name. Could you try fixing that, too? :)

I'll submit another PR if you're too busy/whatever.

fix Database.prototype.replicate()
- should use this.name instead of name
Contributor

klaemo commented Mar 23, 2012

thanks for your feedback. It's fixed in the latest pull request.
Let's hope the changes get merged soon.

Cool :)

Contributor

klaemo commented Mar 27, 2012

@indexzero @cloudhead could you possibly push out a release with these changes? I'd appreciate it. Thanks :)

cloudhead pushed a commit that referenced this pull request Jul 30, 2012

Merge pull request #157 from klaemo/master
fix cradle.Connection.prototype.replicate()

@cloudhead cloudhead merged commit ddf30c8 into flatiron:master Jul 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment