[build 1.0.7] Adhoc routing in browser broken #68

Closed
jvduf opened this Issue Jan 6, 2012 · 4 comments

Comments

Projects
None yet
6 participants

jvduf commented Jan 6, 2012

I wanted to use this adhoc routing but it seems te be broken... How is this possible btw? We're creating builds that are not working correctly :S

See commit ef3b3bf.

Adhoc routing results in Uncaught TypeError: Cannot call method 'concat' of undefined

jvduf commented Jan 6, 2012

@pksunkara can you look at this?

@ghost ghost assigned pksunkara Jan 7, 2012

tblobaum added a commit to tblobaum/director that referenced this issue Jan 9, 2012

Contributor

tblobaum commented Jan 9, 2012

This is failing because there is two var Router locations

var Router inside the browser file is without scope = [], which is called when you use adhoc routing. @jvduf I added your example code and a test for ad-hoc routing.

#70

Owner

indexzero commented Jan 18, 2012

@jvduf @mmalecki @pksunkara Is this fixed now after #70 was cherry-picked?

@mmalecki mmalecki closed this Jan 18, 2012

ydaniv commented Mar 18, 2012

This build is still broken.
I've managed to get something working with a merge of /lib/router and /lib/browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment