Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed some broken named anchors in README.md #150

Merged
merged 6 commits into from

2 participants

@TravisPaul

I fixed some broken named anchors in the README.md that I came across while trying to find out if I'm encountering a bug.

The 'on' and 'before' methods do not seem to get called unless there is also an HTTP verb present. (server-side) Is this intended behavior or is a bug? If this is intended it might be helpful to add to the README.md.

example: https://gist.github.com/3813687

@jfhbrook

Broken anchors fixes look good.

The 'on' and 'before' methods do not seem to get called unless there is also an HTTP verb present.

I believe this may be due to namespace collision issues in the underlying object used for routing. I know we've ran into the issue before of being unable to have a /delete/ path.

@jfhbrook jfhbrook merged commit ef1ca33 into flatiron:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 3 deletions.
  1. +3 −3 README.md
View
6 README.md
@@ -307,7 +307,7 @@ When developing large client-side or server-side applications it is not always p
<a name="scoped-routing"></a>
## Scoped Routing
-In large web appliations, both [Client-side](#client-side) and [Server-side](#server-side), routes are often scoped within a few individual resources. Director exposes a simple way to do this for [Adhoc Routing](#adhoc-routing) scenarios:
+In large web appliations, both [Client-side](#client-side) and [Server-side](#http-routing), routes are often scoped within a few individual resources. Director exposes a simple way to do this for [Adhoc Routing](#adhoc-routing) scenarios:
``` js
var router = new director.http.Router();
@@ -357,7 +357,7 @@ In `director`, a "routing event" is a named property in the [Routing Table](#rou
<a name="configuration"></a>
## Configuration
-Given the flexible nature of `director` there are several options available for both the [Client-side](#client-side) and [Server-side](#server-side). These options can be set using the `.configure()` method:
+Given the flexible nature of `director` there are several options available for both the [Client-side](#client-side) and [Server-side](#http-routing). These options can be set using the `.configure()` method:
``` js
var router = new director.Router(routes).configure(options);
@@ -740,7 +740,7 @@ Configures the Router instance with the specified `options`. See [Configuration]
* token {string}: Named parameter token to set to the specified `matcher`
* matcher {string|Regexp}: Matcher for the specified `token`.
-Adds a route fragment for the given string `token` to the specified regex `matcher` to this Router instance. See [URL Parameters](#url-parameters) for more documentation.
+Adds a route fragment for the given string `token` to the specified regex `matcher` to this Router instance. See [URL Parameters](#url-params) for more documentation.
### on(method, path, route)
* `method` {string}: Method to insert within the Routing Table (e.g. `on`, `get`, etc.).
Something went wrong with that request. Please try again.