Update the exports line to work in node.js, browser and browserify #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow the module to be browserified.
Also make the validate function available in window instead of window.json (inline with revalidator documentation)
|
+1 |
|
👍 |
|
I've been using @facundoolano's branch in node and browserify. It works. |
jcrugzz
added a commit
that referenced
this pull request
Apr 18, 2014
Update the exports line to work in node.js, browser and browserify
|
Can someone |
|
Done! |
|
💖 |
|
Thanks, awesome! |
This was referenced Jun 27, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently revalidtor can't be ported to the browser through browserify, because it checks for the existence of window.
For context on this change see: browserify/browserify#293
Also makes the validate function available in window instead of window.json (inline with the documentation). See: #30